msokolov commented on issue #722: LUCENE-8863: handle some edge cases in Kuromoji DictionaryBuilder, en… URL: https://github.com/apache/lucene-solr/pull/722#issuecomment-502856635 I posted an updated patch that addresses the comments, and also adds a test that exercises the builder with some test data. In order to test, I needed to add the ability to load an "external" dictionary; this enables loading a system dictionary from an alternate location on the classpath, or from an external file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
