rahulgoswami opened a new pull request #740: SOLR-12550 - distribUpdateSoTimeout for configuring socket timeouts in solrcloud doesn't take effect for updates. URL: https://github.com/apache/lucene-solr/pull/740 <!-- Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr: * https://issues.apache.org/jira/projects/LUCENE * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> * SOLR-####: <short description of problem or changes> LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Found this issue on Solr 7.2.1. distribUpdateSoTimeout (configuration property in solr.xml) for configuring socket timeouts in SolrCloud doesn't take effect. This is a fix for the same. We need this property to be configurable to allow for longer socket read timeouts in case of long running commits. # Solution The soTimeout property of ConcurrentUpdateSolrClient class remains null and hence in the method sendUpdateStream(), the default of 600000 ms is set as the timeout in HttpPost class instance variable "method". When the execute() call on underlying HttpClient is finally made, the Httpclient does contain the configured timeout (as in solr.xml or -DdistribUpdateSoTimeout) but gets overridden by the hard default of 600000 in the "method" parameter of the execute() call. The issue is that the builder object which is used to instantiate a ConcurrentUpdateSolrClient in StreamingSolrClients itself doesn't contain the timeout values. This patch fixes that. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [check] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [check] I have created a Jira issue and added the issue ID to my pull request title. - [check] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. - [] I have developed this patch against the `master` branch. - [check] I have run `ant precommit` and the appropriate test suite. - [] I have added tests for my changes. - [] I have added documentation for the Ref Guide (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
