[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

2019-05-23 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-495130339 Will update this PR when #681 is merged, so @noblepaul and @janhoy plz have a look

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

2019-05-21 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-494311665 Added PR for UUID only, will change this PR when it is merged, because unit test will fail otherwise

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

2019-05-17 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-493360696 I splitt up the changes into an additional commit, i think review is pretty easy now if you select next to last in the commit view.

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

2019-05-16 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-493093718 Is it better for you if put the formatting in an seperate commit, i think if i create a new pr this will never get merged,

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

2019-05-16 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-493022833 Pushed again, hope it is enough. Waiting for your suggestions...

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

2019-05-16 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-492957537 The files where formatted with settings generated by 'ant eclipse', so they where wrong before, i can remove the final modifier