[GitHub] lucene-solr issue #317: LUCENE-8145: OffsetsEnum is now unitary

2018-02-01 Thread dsmiley
Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/317 Totally agree on morphing PassageScorer as you describe; I was thinking the same thing. Perhaps a separate issue? I'm not sure how back-compat we should be for that... it's all

[GitHub] lucene-solr issue #317: LUCENE-8145: OffsetsEnum is now unitary

2018-02-01 Thread romseygeek
Github user romseygeek commented on the issue: https://github.com/apache/lucene-solr/pull/317 > we could create a single enum per position query I definitely want to do this! For Spans and phrases, and if intervals ever happen... ---

[GitHub] lucene-solr issue #317: LUCENE-8145: OffsetsEnum is now unitary

2018-02-01 Thread romseygeek
Github user romseygeek commented on the issue: https://github.com/apache/lucene-solr/pull/317 I've moved all scoring into PassageScorer itself, and restored the Passage.setScore() method. One thing I notice now is that the various methods on PassageScorer other than score()

[GitHub] lucene-solr issue #317: LUCENE-8145: OffsetsEnum is now unitary

2018-02-01 Thread dsmiley
Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/317 We think alike @jimczi :-) --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: