[GitHub] lucene-solr issue #455: SOLR-12638

2018-11-28 Thread dsmiley 
Github user dsmiley commented on the issue:

https://github.com/apache/lucene-solr/pull/455
  
What does "so _root_ is not hard-coded into childless documents" mean?  If 
you think SOLR-5211 is missing something, can you please post a patch file to 
the issue and explain what you're adding?


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #455: SOLR-12638

2018-11-28 Thread moshebla 
Github user moshebla commented on the issue:

https://github.com/apache/lucene-solr/pull/455
  
I rebased using the latest master.
I also changed the tests so _root_ is not hard-coded into childless 
documents, since SOLR-5211 was committed to master and ensures this behaviour.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #455: SOLR-12638

2018-10-19 Thread dsmiley 
Github user dsmiley commented on the issue:

https://github.com/apache/lucene-solr/pull/455
  
As a general point, I feel we should prefer "nested" terminology instead of 
"block".  If we were purely working within Lucene then I think "block" might be 
okay but at the Solr layer people see this stuff as "nested" docs.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org