[GitHub] lucene-solr issue #489: SOLR-12955: separate DistribUpdateProcessor to Zk an...
Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/489 There is no "development" branch, so I don't know what you mean by that. You don't _have_ to run the full test suite after each commit, but _ideally_ it ought to pass on each commit if it were to be run. I don't think I will do it. It's up to you to pause on each commit for my input but I don't think necessary since I'm overall happy with the final result, I just want to see the incremental steps to observe where the code is going at each juncture. When I finally commit something, I'm not sure yet if I'm going to do it in one commit or do it separately... but don't let that stop you from breaking it into as small steps as you please. Please use commit comments to point out anything non-obvious. The purpose here is mostly to show what went where since a single all-in-one change is kinda unreviewable (or at least would require committing in blind faith). --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #489: SOLR-12955: separate DistribUpdateProcessor to Zk an...
Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/489 @dsmiley, would you want this to be separated to different commits on the development branch, so you can view each one and review them separately, or would you like to commit each one to master and ensure no tests failure occurs after each commit? I have started hacking away on a separate branch, and the PR can be viewed [here](https://github.com/apache/lucene-solr/pull/519). --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #489: SOLR-12955: separate DistribUpdateProcessor to Zk an...
Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/489 I will rebase this PR on the latest master. It is going to be quite hard to separate this into smaller changes, since I tried not to change the core logic where possible, and instead remove the if clauses(if zkEnabled) and disjoin them into two distinct classes.Alas, --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
