[GitHub] lucene-solr issue #50: SOLR-9280 - make nodeName a configurable parameter in...

2016-10-17 Thread kelaban
Github user kelaban commented on the issue:

https://github.com/apache/lucene-solr/pull/50
  
Additionally work for SOLR-9281 is being done here 
(https://github.com/kelaban/lucene-solr/tree/jira/master/SOLR-9281) but will 
hold out on a PR as it relies on this branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr issue #50: SOLR-9280 - make nodeName a configurable parameter in...

2016-10-17 Thread kelaban
Github user kelaban commented on the issue:

https://github.com/apache/lucene-solr/pull/50
  
Updated so the patch now applies cleanly. I've been having trouble getting 
tests to pass on vanilla master branch, so I cannot tell if this is causing any 
to fail. I've spot checked a few tests with this patch and they worked fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr issue #50: SOLR-9280 - make nodeName a configurable parameter in...

2016-07-08 Thread kelaban
Github user kelaban commented on the issue:

https://github.com/apache/lucene-solr/pull/50
  
Randomly setting nodeName in tests which extend from 
`AbstractFullDistribZkTestBase` hits about 60 solr cloud tests. But there are 
also about 30 other cloud tests which use `MiniSolrCloudCluster` which will  
not get this randomness applied. To increase coverage we can add randomness 
into this class as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org