[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-29 Thread moshebla
Github user moshebla closed the pull request at: https://github.com/apache/lucene-solr/pull/416 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213543737 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -124,10 +124,11 @@ public void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213541579 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -124,10 +124,11 @@ public void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213540255 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -123,6 +124,16 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213321225 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -109,9 +109,14 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213319927 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -99,6 +96,9 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213306038 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -109,9 +109,14 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213295374 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -99,6 +96,9 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213291939 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213292329 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -109,9 +109,14 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213270075 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213202931 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -238,6 +238,17 @@ public void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-27 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r212993235 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -92,6 +97,18 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-27 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r213001520 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -238,6 +238,17 @@ public void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211599253 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211595662 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211595043 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -0,0 +1,346 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211594271 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -0,0 +1,346 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211594079 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -0,0 +1,346 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211519256 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -264,7 +309,7 @@ private static Object

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211505124 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -264,7 +309,7 @@ private static Object

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-21 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211495503 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -40,22 +43,52 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-20 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211315461 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -40,22 +43,52 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-20 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211255381 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -40,22 +43,52 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-20 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211258577 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -40,22 +43,52 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-20 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211259141 --- Diff: solr/core/src/test-files/solr/collection1/conf/schema-nest.xml --- @@ -20,6 +20,9 @@ + --- End diff --

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-20 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211256948 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -264,7 +309,7 @@ private static Object

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-20 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211257783 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -40,22 +43,52 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-19 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r211108109 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -87,7 +87,12 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-16 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210600024 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -87,7 +87,12 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210482225 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -87,7 +87,12 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210478700 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -87,7 +87,12 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210475699 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -291,4 +302,15 @@ private static String

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210322853 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -291,4 +302,15 @@ private static String

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210322181 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -87,7 +87,12 @@ public void transform(SolrDocument

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210309845 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -227,27 +225,28 @@ private static String

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210306003 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -227,27 +225,28 @@ private static String

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210294082 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -224,9 +225,29 @@ private static String

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210291464 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210290075 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210288829 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210287119 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210287034 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210285891 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210280357 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210273819 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210274031 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -224,9 +225,29 @@ private static String

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210271399 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210263030 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-15 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r210262386 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -81,8 +81,8 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-14 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209862802 --- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml --- @@ -567,7 +567,17 @@ - + + +

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209070327 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209069776 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java --- @@ -70,109 +73,59 @@ public DocTransformer

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209066014 --- Diff: solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java --- @@ -107,8 +107,8 @@ public void testDeeplyNestedURPGrandChild()

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209071109 --- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml --- @@ -567,7 +567,17 @@ - + + +

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209067568 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -0,0 +1,249 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209070656 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java --- @@ -61,6 +57,13 @@ */ public class

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r209068211 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208932604 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-09 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208928799 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208813471 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208813169 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208807039 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208799313 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208507249 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java --- @@ -32,7 +32,7 @@ import

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208507038 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -242,10 +242,10 @@ private void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-08 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r208506508 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java --- @@ -66,34 +66,34 @@ public void testAllParams()

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-01 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206901995 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -168,35 +172,57 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-01 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206892630 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-08-01 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206846562 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-30 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206184346 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-30 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206034965 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -168,35 +172,57 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-29 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206012956 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -168,35 +172,57 @@ private static

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-29 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206011853 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-29 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r206011552 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-29 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205965045 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-29 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205962085 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,227 @@ +/* + *

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205961339 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205960639 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205960593 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-27 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205851891 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,227 @@ +/* + *

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205468112 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205488727 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,227 @@ +/* + *

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205477055 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205466774 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205475640 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205475272 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205480076 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205474348 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205482972 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,227 @@ +/* + *

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205478036 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205468966 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205477315 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205465998 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java --- @@ -91,15 +100,37 @@ public DocTransformer

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205465327 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java --- @@ -70,36 +86,62 @@ public DocTransformer

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205463666 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java --- @@ -61,6 +71,12 @@ */ public class

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205467807 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,224 @@ +/* + * Licensed to

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-26 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205403130 --- Diff: solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java --- @@ -0,0 +1,163 @@ +/* + *

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-25 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205126064 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java --- @@ -132,54 +126,49 @@ public void

[GitHub] lucene-solr pull request #416: WIP: SOLR-12519

2018-07-25 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/416#discussion_r205125247 --- Diff: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java --- @@ -67,7 +73,9 @@ public static

  1   2   >