GitHub user javanna opened a pull request:

    https://github.com/apache/lucene-solr/pull/511

    Remove k1+1 from the numerator of  BM25Similarity

    Patch for https://issues.apache.org/jira/browse/LUCENE-8563.
    
    This PR removes the k1+1 factor from the numerator of `BM25Similarity` and 
adds a new `LegacyBM25Similarity` under misc that exposes the old behaviour. 
Note that I haven't found a way to easily reproduce the previous behaviour in 
the explain method, so I left that part out of `LegacyBM25Similarity` for now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/javanna/lucene-solr 
lucene-8563_bm25_k1_numerator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #511
    
----
commit c665ed04b94f330fe27deec781cc1c59d45fddb5
Author: javanna <cavannaluca@...>
Date:   2018-11-14T09:51:48Z

    Remove k1+1 constant factor from BM25 formula numerator

commit 1b3714410771b53d30f29c78f27c37c617dea85c
Author: javanna <cavannaluca@...>
Date:   2018-11-14T11:15:39Z

    adapt TestFunctionQuery

commit 7f56226906ededdc285877c429a00dae4f5a6d10
Author: javanna <cavannaluca@...>
Date:   2018-11-14T14:08:38Z

    adapt TestPayloadScoreQParserPlugin

commit 870d1d79afef7800ec348fabbe7b14b1a11ae1c0
Author: javanna <cavannaluca@...>
Date:   2018-11-14T16:32:53Z

    add migrate note

commit 5f0a0b0fb0ec7ebad8094f7fa97a09c877d3a1cb
Author: javanna <cavannaluca@...>
Date:   2018-11-27T21:15:12Z

    add LegacyBM25Similarity

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to