[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/521 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-10 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/521#discussion_r240294342 --- Diff: lucene/CHANGES.txt --- @@ -268,6 +268,9 @@ Optimizations can safe up to 80% of the heap used compared to the previous implementation

[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-10 Thread s1monw
Github user s1monw commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/521#discussion_r240234021 --- Diff: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesFieldUpdates.java --- @@ -53,14 +55,28 @@ BytesRef binaryValue() {

[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-10 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/521#discussion_r240152127 --- Diff: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesFieldUpdates.java --- @@ -53,14 +55,28 @@ BytesRef binaryValue() {

[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-10 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/521#discussion_r240152341 --- Diff: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesFieldUpdates.java --- @@ -53,14 +55,28 @@ BytesRef binaryValue() {

[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-09 Thread s1monw
Github user s1monw commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/521#discussion_r240047328 --- Diff: lucene/core/src/test/org/apache/lucene/index/Benchmark.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #521: LUCENE-8598: Improve field updates packed val...

2018-12-09 Thread s1monw
GitHub user s1monw opened a pull request: https://github.com/apache/lucene-solr/pull/521 LUCENE-8598: Improve field updates packed values DocValuesFieldUpdats are using compact settings for packet ints that causes dramatic slowdowns when the updates are finished and sorted.