[GitHub] lucene-solr pull request #96: SOLR-6246 - Fix core reload if suggester has b...

[Peter-LaComb]

Github user Peter-LaComb closed the pull request at:

https://github.com/apache/lucene-solr/pull/96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #96: SOLR-6246 - Fix core reload if suggester has b...

[Peter-LaComb]

GitHub user Peter-LaComb opened a pull request:

https://github.com/apache/lucene-solr/pull/96

SOLR-6246 - Fix core reload if suggester has been built.

In my testing, it is not required to keep the writer open for the suggester 
to keep working.
Add and Update call ensureOpen, which will open a new writer if it has been 
set = null.
This change closes it at the end of a build and sets the reference = null 
such that
Add and Update will continue to work correctly. Additionally, commit is 
updated to not
throw if the writer is null. This is correct because nothing has been added 
or updated
since the last build.
The only thing I'm left with uncertainty about is reloading a core with NRT 
updates
pending. This would appear to still cause the issue to appear again. The 
difference being that
a rebuild would alleviate the issue. This requires additional thought.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Peter-LaComb/lucene-solr bugfix/SOLR-6246

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96


commit c31db2f53b431ccb3263c824c7d5fde20aab5293
Author: Peter T. LaComb Jr 
Date:   2016-10-13T20:28:25Z

SOLR-6246 - Fix core reload if suggester has been built.
In my testing, it is not required to keep the writer open for the suggester 
to keep working.
Add and Update call ensureOpen, which will open a new writer if it has been 
set = null.
This change closes it at the end of a build and sets the reference = null 
such that
Add and Update will continue to work correctly. Additionally, commit is 
updated to not
throw if the writer is null. This is correct because nothing has been added 
or updated
since the last build.
The only thing I'm left with uncertainty about is reloading a core with NRT 
updates
pending. This would appear to still cause the issue to appear again. The 
difference being that
a rebuild would alleviate the issue. This requires additional thought.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org