[jira] [Assigned] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
[ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reassigned SOLR-9777: -- Assignee: Ishan Chattopadhyaya (was: Noble Paul) > IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of > getCoreCacheKey() for per-segment caching > - > > Key: SOLR-9777 > URL: https://issues.apache.org/jira/browse/SOLR-9777 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Ishan Chattopadhyaya >Assignee: Ishan Chattopadhyaya > Attachments: SOLR-9777.patch > > > [Note: Had initially posted to SOLR-9506, but now moved here] > While working on SOLR-5944, I realized that the current per segment caching > logic works fine for deleted documents (due to comparison of numDocs in a > segment for the criterion of cache hit/miss). However, if a segment has > docValues updates, the same logic is insufficient. It is my understanding > that changing the key for caching from reader().getCoreCacheKey() to > reader().getCombinedCoreAndDeletesKey() would work here, since the docValues > updates are internally handled using deletion queue and hence the "combined" > core and deletes key would work here. Attaching a patch for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Assigned] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
[ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-9777: Assignee: Noble Paul > IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of > getCoreCacheKey() for per-segment caching > - > > Key: SOLR-9777 > URL: https://issues.apache.org/jira/browse/SOLR-9777 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Ishan Chattopadhyaya >Assignee: Noble Paul > Attachments: SOLR-9777.patch > > > [Note: Had initially posted to SOLR-9506, but now moved here] > While working on SOLR-5944, I realized that the current per segment caching > logic works fine for deleted documents (due to comparison of numDocs in a > segment for the criterion of cache hit/miss). However, if a segment has > docValues updates, the same logic is insufficient. It is my understanding > that changing the key for caching from reader().getCoreCacheKey() to > reader().getCombinedCoreAndDeletesKey() would work here, since the docValues > updates are internally handled using deletion queue and hence the "combined" > core and deletes key would work here. Attaching a patch for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
