[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555229#comment-14555229 ]
Robert Muir edited comment on LUCENE-6494 at 5/21/15 11:08 PM: --------------------------------------------------------------- I think what is in branch_5x (LUCENE-6371 and LUCENE-6490) should not be released in its current state. All of this was added in the last 2 days and I think its too close to the release. IMO this patch simplifies things a lot. But this patch needs maybe 2 or 3 days work, and a few weeks baking (maybe with followup issues/improvements) and it would be really good. A 5.3 doesn't have to be months after a 5.2... edit: trunk->branch_5x because we can just iterate from trunk (we have a patch here doing just exactly that), my concerns are only about the release. was (Author: rcmuir): I think what is in trunk (LUCENE-6371 and LUCENE-6490) should not be released in its current state. All of this was added in the last 2 days and I think its too close to the release. IMO this patch simplifies things a lot. But this patch needs maybe 2 or 3 days work, and a few weeks baking (maybe with followup issues/improvements) and it would be really good. A 5.3 doesn't have to be months after a 5.2... > Make PayloadSpanUtil apply to other postings information > -------------------------------------------------------- > > Key: LUCENE-6494 > URL: https://issues.apache.org/jira/browse/LUCENE-6494 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Fix For: 5.2 > > Attachments: LUCENE-6494.patch, LUCENE-6494.patch, LUCENE-6494.patch, > LUCENE-6494.patch > > > With the addition of SpanCollectors, we can now get arbitrary postings > information from SpanQueries. PayloadSpanUtil does some rewriting to convert > non-span queries into SpanQueries so that it can collect payloads. It would > be good to make this more generic, so that we can collect any postings > information from any query (without having to make invasive changes to > already optimized Scorers, etc). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org