[
https://issues.apache.org/jira/browse/LUCENE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519517#comment-16519517
]
Nicholas Knize edited comment on LUCENE-8364 at 6/21/18 3:36 PM:
-----------------------------------------------------------------
I agree with that. That's why I left {{LatLonPointInPolygonQuery}} using
{{Polygon2D}} but refactored the name to {{GeoEdgeTree}}. (hoping to make it a
little more clear to what the class actually is). I'd like to make
{{Polygon2D}} package private to the same package as
{{LatLonPointInPolygonQuery}} (since that's the only place it should be used)
but all {{LatLonPoint*}} still lives in sandbox. So perhaps the first step
should be to graduate LatLonPoint to either core or spatial module as discussed
in LUCENE-7314
was (Author: nknize):
I agree with that. That's why I left {{LatLonPointInPolygonQuery}} using
{{Polygon2D}} but refactored the name to {{GeoEdgeTree}}. (hoping to make it a
little more clear to what the class actually is). I'd like to make
{{Polygon2D}} package private to the same package as
{{LatLonPointInPolygonQuery}} but all {{LatLonPoint*}} still lives in sandbox.
So perhaps the first step should be to graduate LatLonPoint to either core or
spatial module as discussed in LUCENE-7314
> Refactor and clean up core geo api
> ----------------------------------
>
> Key: LUCENE-8364
> URL: https://issues.apache.org/jira/browse/LUCENE-8364
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Nicholas Knize
> Priority: Major
> Attachments: LUCENE-8364.patch
>
>
> The core geo API is quite disorganized and confusing. For example there is
> {{Polygon}} for creating an instance of polygon vertices and holes and
> {{Polygon2D}} for computing relations between points and polygons. There is
> also a {{PolygonPredicate}} and {{DistancePredicate}} in {{GeoUtils}} for
> computing point in polygon and point distance relations, respectively, and a
> {{GeoRelationUtils}} utility class which is no longer used for anything. This
> disorganization is due to the organic improvements of simple {{LatLonPoint}}
> indexing and search features and a little TLC is needed to clean up api to
> make it more approachable and easy to understand.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
