[ https://issues.apache.org/jira/browse/SOLR-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863699#comment-15863699 ]
Yonik Seeley edited comment on SOLR-10121 at 2/13/17 2:17 PM: -------------------------------------------------------------- I reviewed the pertinent BlockCache and haven't seen any thread safety issues yet. Looking at the history of BlockCache, I reverted to right before SOLR-7355 was applied, and the issues went away. So it looks like it could be a thread safety or usage issue with Caffeine? [~ben.manes], does putting a key/value in Caffeine constitute safe publication to a different thread (as is the case with ConcurrentHashMap for example)? Note that this doesn't necessarily mean something is wrong with Caffeine... it may be that the increased concurrency or other allowable differences in behavior uncover a bug in BlockCache as well. was (Author: ysee...@gmail.com): I reviewed the pertinent BlockCache and couldn't see any thread safety issues. Looking at the history of BlockCache, I reverted to right before SOLR-7355 was applied, and the issues went away. So it looks like a thread safety or usage issue with Caffeine? [~ben.manes], does putting a key/value in Caffeine constitute safe publication to a different thread (as is the case with ConcurrentHashMap for example)? > BlockCache corruption with high concurrency > ------------------------------------------- > > Key: SOLR-10121 > URL: https://issues.apache.org/jira/browse/SOLR-10121 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Yonik Seeley > Assignee: Yonik Seeley > > Improving the tests of the BlockCache in SOLR-10116 uncovered a corruption > bug (either that or the test is flawed... TBD). > The failing test is TestBlockCache.testBlockCacheConcurrent() -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org