[ 
https://issues.apache.org/jira/browse/SOLR-10908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082742#comment-16082742
 ] 

Rohit edited comment on SOLR-10908 at 7/11/17 6:46 PM:
-------------------------------------------------------

Added check in function CloudSolrStream.toExpression to correct the behaviour 
for fq parameter.
Post fix:

ExpressionString: search(collection1,q="*:*",fl="id,a_s,a_i,a_f",sort="a_f asc, 
a_i 
asc",*{color:#205081}fq="a_s:one",fq="a_s:two"{color}*,zkHost="testhost:1234")

Requesting you to please review the patch and provide any suggestions that you 
see fit.


was (Author: rohitcse):
Added check in function CloudSolrStream.toExpression to correct the behaviour 
for fq parameter.
Post fix:

ExpressionString: search(collection1,q="*:*",fl="id,a_s,a_i,a_f",sort="a_f asc, 
a_i 
asc",*{color:#205081}fq="a_s:one",fq="a_s:two"{color}*,zkHost="testhost:1234")

> CloudSolrStream.toExpression (and perhaps others) incorrectly handles fq 
> clauses
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-10908
>                 URL: https://issues.apache.org/jira/browse/SOLR-10908
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 6.6, 7.0
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-10229.patch, SOLR-10908.patch
>
>
> toExpression in at least CloudSolrStream concatenates parameters in a 
> comma-separated list. This is fine for things like sorting but incorrect for 
> fq clauses. If my input is something like
> fq=condition1
> fq=condition2
> it winds up being something like
> fq=condition1,condition2
> I've seen it in this class for this parameter, other classes and other 
> parameters might have the same problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to