[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610771#comment-13610771
]
Commit Tag Bot commented on LUCENE-2308:
[branch_4x commit] Michael McCandless
ht
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281892#comment-13281892
]
Simon Willnauer commented on LUCENE-2308:
-
can we close this issue? seems like ex
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185094#comment-13185094
]
Yonik Seeley commented on LUCENE-2308:
--
We're coming up on 4.0, and it doesn't seem
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102210#comment-13102210
]
Chris Male commented on LUCENE-2308:
Committed revision 1167668.
> Separately specif
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100227#comment-13100227
]
Uwe Schindler commented on LUCENE-2308:
---
bq. I am not green but gave up due to vaca
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100226#comment-13100226
]
Chris Male commented on LUCENE-2308:
Far from it Uwe, your complaints are being activ
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100222#comment-13100222
]
Uwe Schindler commented on LUCENE-2308:
---
I am not green but gave up due to vacation
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098957#comment-13098957
]
Chris Male commented on LUCENE-2308:
I will make the appropriate javadoc changes righ
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098904#comment-13098904
]
Michael McCandless commented on LUCENE-2308:
Should we also move numeric(), n
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098899#comment-13098899
]
Michael McCandless commented on LUCENE-2308:
I guess it's OK to remove the au
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098051#comment-13098051
]
Yonik Seeley commented on LUCENE-2308:
--
Instead of introducing a dependency on CoreF
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098032#comment-13098032
]
Chris Male commented on LUCENE-2308:
Anyone else have any thoughts? Any objections to
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096539#comment-13096539
]
Chris Male commented on LUCENE-2308:
I would like it to be but Field ensures any Fiel
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096167#comment-13096167
]
Yonik Seeley commented on LUCENE-2308:
--
Regarding the latest patch:
{code}
- publi
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095074#comment-13095074
]
Mark Miller commented on LUCENE-2308:
-
We should probably really let the dust settle
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095017#comment-13095017
]
Chris Male commented on LUCENE-2308:
{quote}
I would like to have an on-list vote, pl
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095016#comment-13095016
]
Chris Male commented on LUCENE-2308:
Just when I thought we had some consensus...
{q
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094665#comment-13094665
]
Uwe Schindler commented on LUCENE-2308:
---
bq. However whether or not people agree wi
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094664#comment-13094664
]
Robert Muir commented on LUCENE-2308:
-
{quote}
I agree massive single ctor isn't grea
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094662#comment-13094662
]
Yonik Seeley commented on LUCENE-2308:
--
Since it seems like there is no agreement on
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094656#comment-13094656
]
Uwe Schindler commented on LUCENE-2308:
---
bq. The only reason we want immutability h
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094638#comment-13094638
]
Chris Male commented on LUCENE-2308:
LUCENE-3410 for WDF improvements.
> Separately
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094632#comment-13094632
]
Michael McCandless commented on LUCENE-2308:
bq. Even as one-line its much be
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094629#comment-13094629
]
Robert Muir commented on LUCENE-2308:
-
{quote}
Uwe, lets open an issue to look at imp
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094619#comment-13094619
]
Chris Male commented on LUCENE-2308:
So I want to get some actions out of this:
Uwe,
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094618#comment-13094618
]
Uwe Schindler commented on LUCENE-2308:
---
bq. I don't like that the chained setters
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094615#comment-13094615
]
Uwe Schindler commented on LUCENE-2308:
---
This is still more readable than
{code:j
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094606#comment-13094606
]
Michael McCandless commented on LUCENE-2308:
bq. Builder patterns can be form
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094575#comment-13094575
]
Chris Male commented on LUCENE-2308:
Ah sorry, when I last looked at them some had co
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094570#comment-13094570
]
Chris Male commented on LUCENE-2308:
{quote}
I think the ideal situation is where Str
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094572#comment-13094572
]
Robert Muir commented on LUCENE-2308:
-
well, looking at them, thats what they are now
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094567#comment-13094567
]
Robert Muir commented on LUCENE-2308:
-
{quote}
Okay so we seem to have consensus on m
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094564#comment-13094564
]
Uwe Schindler commented on LUCENE-2308:
---
In my opinion, we should vote for the foll
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094557#comment-13094557
]
Uwe Schindler commented on LUCENE-2308:
---
Freezeable is an antipattern and produces
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094551#comment-13094551
]
Chris Male commented on LUCENE-2308:
Okay so we seem to have consensus on moving to a
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094548#comment-13094548
]
Chris Male commented on LUCENE-2308:
I don't see anything wrong with providing option
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094547#comment-13094547
]
Robert Muir commented on LUCENE-2308:
-
But if fieldtype is an interface with get-only
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094543#comment-13094543
]
Uwe Schindler commented on LUCENE-2308:
---
I disagree, because that would again creat
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094541#comment-13094541
]
Chris Male commented on LUCENE-2308:
Err Yonik pointed out that we still have the opt
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094539#comment-13094539
]
Chris Male commented on LUCENE-2308:
Alright, so can we move towards a consensus on a
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094532#comment-13094532
]
Yonik Seeley commented on LUCENE-2308:
--
bq. I think we should have an oal.index.Fiel
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094531#comment-13094531
]
Robert Muir commented on LUCENE-2308:
-
{quote}
So yes, Lucene's core can stay lean an
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094529#comment-13094529
]
Chris Male commented on LUCENE-2308:
{quote}
The pro-builders on this issue just sile
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094527#comment-13094527
]
Robert Muir commented on LUCENE-2308:
-
I care, thats why i am -1 to the builder patte
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094526#comment-13094526
]
Uwe Schindler commented on LUCENE-2308:
---
If we release the code with the builder pa
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094522#comment-13094522
]
Robert Muir commented on LUCENE-2308:
-
{quote}
In general the constructor of the immu
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094517#comment-13094517
]
Simon Willnauer commented on LUCENE-2308:
-
awesome writeup uwe! thank you!
> Sep
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094514#comment-13094514
]
Uwe Schindler commented on LUCENE-2308:
---
I am on opposite side:
In general the con
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094502#comment-13094502
]
Chris Male commented on LUCENE-2308:
Didn't Simon suggest we add the big-ctor version
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094499#comment-13094499
]
Michael McCandless commented on LUCENE-2308:
bq. Change FieldType to an inter
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094496#comment-13094496
]
Robert Muir commented on LUCENE-2308:
-
Its shared only if the person reuses them expl
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094492#comment-13094492
]
Chris Male commented on LUCENE-2308:
I'm confused about what the reuse of Field objec
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094491#comment-13094491
]
Simon Willnauer commented on LUCENE-2308:
-
bq. Second time this morning you didn'
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094489#comment-13094489
]
Robert Muir commented on LUCENE-2308:
-
{quote}
The Builder itsself is mutable.
{quote
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094486#comment-13094486
]
Uwe Schindler commented on LUCENE-2308:
---
Thats not a bug if you implement it correc
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094485#comment-13094485
]
Robert Muir commented on LUCENE-2308:
-
{quote}
just to get this straight, FT is creat
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094482#comment-13094482
]
Simon Willnauer commented on LUCENE-2308:
-
just to get this straight, FT is creat
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094478#comment-13094478
]
Robert Muir commented on LUCENE-2308:
-
{quote}
In general the builder pattern can als
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094476#comment-13094476
]
Uwe Schindler commented on LUCENE-2308:
---
bq. How does it create too many objects?
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094477#comment-13094477
]
Robert Muir commented on LUCENE-2308:
-
we have to realize, most people indexing with
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094466#comment-13094466
]
Chris Male commented on LUCENE-2308:
How does it create too many objects?
> Separate
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094462#comment-13094462
]
Robert Muir commented on LUCENE-2308:
-
{quote}
so I haven't seen a single technical a
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094379#comment-13094379
]
Uwe Schindler commented on LUCENE-2308:
---
Somehow related, but for the same reasons
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094378#comment-13094378
]
Uwe Schindler commented on LUCENE-2308:
---
+1
I agree, too! I am personally in favou
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094371#comment-13094371
]
Chris Male commented on LUCENE-2308:
+1
I couldn't have put it better myself.
> Sep
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094364#comment-13094364
]
Simon Willnauer commented on LUCENE-2308:
-
Hey guys, why don't we put plain old i
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094293#comment-13094293
]
Chris Male commented on LUCENE-2308:
What about a compromise and have both the plain
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094272#comment-13094272
]
Chris Male commented on LUCENE-2308:
Then we're at a bit of an impasse because you're
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094266#comment-13094266
]
Robert Muir commented on LUCENE-2308:
-
I'm not really motivated to work on a patch wi
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094265#comment-13094265
]
Chris Male commented on LUCENE-2308:
Alright, I'll wait to see your patch using the c
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094263#comment-13094263
]
Robert Muir commented on LUCENE-2308:
-
it doesn't lock us into anything. we deprecate
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094260#comment-13094260
]
Chris Male commented on LUCENE-2308:
The problem is that it locks us in to this limit
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094258#comment-13094258
]
Robert Muir commented on LUCENE-2308:
-
bq. I'm definitely -1 for a constructor for al
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094256#comment-13094256
]
Chris Male commented on LUCENE-2308:
I'm definitely -1 for a constructor for all the
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093895#comment-13093895
]
Robert Muir commented on LUCENE-2308:
-
{quote}
Add a builder for FieldType to documen
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093880#comment-13093880
]
Chris Male commented on LUCENE-2308:
Much of what has been suggested here I'm looking
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093856#comment-13093856
]
Michael McCandless commented on LUCENE-2308:
bq. I think FT should be immut
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093816#comment-13093816
]
Robert Muir commented on LUCENE-2308:
-
Thanks Mike! This is really helpful!
While re
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093075#comment-13093075
]
Michael McCandless commented on LUCENE-2308:
bq. Can we add some stuff to MIG
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093018#comment-13093018
]
Robert Muir commented on LUCENE-2308:
-
Can we add some stuff to MIGRATE.txt for this
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092297#comment-13092297
]
Chris Male commented on LUCENE-2308:
Yay! Great work Nikola, Mike.
> Separately spec
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092291#comment-13092291
]
Michael McCandless commented on LUCENE-2308:
OK I committed the final patch!
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091095#comment-13091095
]
Nikola Tankovic commented on LUCENE-2308:
-
Well this GSOC was definitively a plea
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091093#comment-13091093
]
Michael McCandless commented on LUCENE-2308:
Thank you for all this hard work
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091090#comment-13091090
]
Nikola Tankovic commented on LUCENE-2308:
-
Congratulations, I think we did it :)
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088357#comment-13088357
]
Michael McCandless commented on LUCENE-2308:
Well, the test is heavily thread
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088349#comment-13088349
]
Nikola Tankovic commented on LUCENE-2308:
-
That's strange 'cause on my machine al
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088336#comment-13088336
]
Michael McCandless commented on LUCENE-2308:
Looks good Nikola -- I'll commit
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086656#comment-13086656
]
Michael McCandless commented on LUCENE-2308:
Great progress! I'll commit sho
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086144#comment-13086144
]
Nikola Tankovic commented on LUCENE-2308:
-
Great Mike, you did it all!
> Separat
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086042#comment-13086042
]
Michael McCandless commented on LUCENE-2308:
OK I resolved the cases of Field
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086034#comment-13086034
]
Michael McCandless commented on LUCENE-2308:
Patch looks good -- I'll commit,
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085531#comment-13085531
]
Nikola Tankovic commented on LUCENE-2308:
-
Nice,
I'll do my best to be as quick
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085377#comment-13085377
]
Michael McCandless commented on LUCENE-2308:
Awesome, thanks Robert!
Nikola,
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085374#comment-13085374
]
Robert Muir commented on LUCENE-2308:
-
I committed mike's patch as
https://svn.apach
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085177#comment-13085177
]
Michael McCandless commented on LUCENE-2308:
Patch looks good -- I'll commit
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082366#comment-13082366
]
Michael McCandless commented on LUCENE-2308:
Thanks Nikola.
I'll have a look
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079798#comment-13079798
]
Nikola Tankovic commented on LUCENE-2308:
-
YES! Indeed a big milestone, finally :
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079461#comment-13079461
]
Michael McCandless commented on LUCENE-2308:
Patch looks great... such a big
[
https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076033#comment-13076033
]
Nikola Tankovic commented on LUCENE-2308:
-
Yes, exactly! That is my next step, sh
1 - 100 of 136 matches
Mail list logo
