[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155094#comment-13155094
]
Uwe Schindler commented on LUCENE-3464:
---
I will add a comment to the javadocs with
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154434#comment-13154434
]
Robert Muir commented on LUCENE-3464:
-
{quote}
The problem: This cannot be
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154437#comment-13154437
]
Simon Willnauer commented on LUCENE-3464:
-
bq. I don't understand this statement,
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154440#comment-13154440
]
Uwe Schindler commented on LUCENE-3464:
---
This code does not compile (fails by
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154442#comment-13154442
]
Uwe Schindler commented on LUCENE-3464:
---
bq. Thats no problem, it just calls
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154441#comment-13154441
]
Robert Muir commented on LUCENE-3464:
-
Uwe, see my patch, it uses its own
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1315#comment-1315
]
Robert Muir commented on LUCENE-3464:
-
In my patch FIR returns whatever the
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154445#comment-13154445
]
Uwe Schindler commented on LUCENE-3464:
---
Robert read my comment about the reason
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154448#comment-13154448
]
Uwe Schindler commented on LUCENE-3464:
---
Robert: If you wrap a standard
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154449#comment-13154449
]
Robert Muir commented on LUCENE-3464:
-
As I said before, this is simple, FIR's impl
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154456#comment-13154456
]
Uwe Schindler commented on LUCENE-3464:
---
bq. As I said before, this is simple,
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154463#comment-13154463
]
Robert Muir commented on LUCENE-3464:
-
{quote}
Not in your proof of concept. And this
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154468#comment-13154468
]
Robert Muir commented on LUCENE-3464:
-
And just again: I want to point out this is
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120014#comment-13120014
]
Uwe Schindler commented on LUCENE-3464:
---
This sophisticated backwards seems fine.
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114492#comment-13114492
]
Simon Willnauer commented on LUCENE-3464:
-
just a couple of variants:
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114521#comment-13114521
]
Martijn van Groningen commented on LUCENE-3464:
---
+1 reopenOnChange()
Names
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114656#comment-13114656
]
Doron Cohen commented on LUCENE-3464:
-
I liked reopen()... (but also like returning
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114662#comment-13114662
]
Ryan McKinley commented on LUCENE-3464:
---
maybe:
reopenIfChanged()
reopenOnChange
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114667#comment-13114667
]
Uwe Schindler commented on LUCENE-3464:
---
We can even do the change in 3.x, if we
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114748#comment-13114748
]
Michael McCandless commented on LUCENE-3464:
I like reopenIfChanged too!
bq.
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114760#comment-13114760
]
Michael McCandless commented on LUCENE-3464:
bq. Can we just make it final
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114795#comment-13114795
]
Michael McCandless commented on LUCENE-3464:
Another trappiness I've seen on
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115030#comment-13115030
]
Ryan McKinley commented on LUCENE-3464:
---
bq. the method implies that the reopen
[
https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114354#comment-13114354
]
Mark Miller commented on LUCENE-3464:
-
bq. reopenIfNeeded
+1 - can't think of
24 matches
Mail list logo
