[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-15 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150399#comment-13150399 ] Robert Muir commented on LUCENE-3569: - {quote} Mike suggested that we keep MP passed

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-15 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150405#comment-13150405 ] Michael McCandless commented on LUCENE-3569: For natural merges I think the

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-14 Thread Hoss Man (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149881#comment-13149881 ] Hoss Man commented on LUCENE-3569: -- {quote} I would add an instanceof check so that this

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149894#comment-13149894 ] Robert Muir commented on LUCENE-3569: - {quote} Are you also going to hack

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-14 Thread Shai Erera (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150233#comment-13150233 ] Shai Erera commented on LUCENE-3569: bq. Maintenance of what? Segment management is

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-14 Thread Hoss Man (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150253#comment-13150253 ] Hoss Man commented on LUCENE-3569: -- bq. Why would they need to interact? Maybe this is

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-14 Thread Shai Erera (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150255#comment-13150255 ] Shai Erera commented on LUCENE-3569: I get your point. Today, it is also possible for

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146968#comment-13146968 ] Robert Muir commented on LUCENE-3569: - i dont like pushing optimize-type merging into

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Shai Erera (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146984#comment-13146984 ] Shai Erera commented on LUCENE-3569: {code} i dont like pushing optimize-type merging

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146986#comment-13146986 ] Robert Muir commented on LUCENE-3569: - {quote} We cannot really prevent it - someone

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146988#comment-13146988 ] Robert Muir commented on LUCENE-3569: - {quote} If the MP's name is clear enough that

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Shai Erera (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146992#comment-13146992 ] Shai Erera commented on LUCENE-3569: What instanceof are you talking about? There

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147006#comment-13147006 ] Robert Muir commented on LUCENE-3569: - I would add an instanceof check so that this

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Shai Erera (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147018#comment-13147018 ] Shai Erera commented on LUCENE-3569: Ok then add the instanceof check. Easily

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147053#comment-13147053 ] Mark Miller commented on LUCENE-3569: - Not a big fan of the maintenance name. Anyone

[jira] [Commented] (LUCENE-3569) Consolidate IndexWriter's optimize, maybeMerge and expungeDeletes under one merge(MP) method

2011-11-09 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147390#comment-13147390 ] Michael McCandless commented on LUCENE-3569: Maybe the new maintenance class