[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403805#comment-13403805
]
Dawid Weiss commented on LUCENE-3832:
-
It'd be possible to avoid the sort and still
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402945#comment-13402945
]
Dawid Weiss commented on LUCENE-3832:
-
Passes tests for me, I'll commit it in soon if
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402958#comment-13402958
]
Robert Muir commented on LUCENE-3832:
-
I don't like the one that takes CharSequence
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402969#comment-13402969
]
Dawid Weiss commented on LUCENE-3832:
-
I don't like many things. For example the fact
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402972#comment-13402972
]
Robert Muir commented on LUCENE-3832:
-
{quote}
For example the fact that it accepts
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402974#comment-13402974
]
Dawid Weiss commented on LUCENE-3832:
-
You pass an array of bytes and get codepoint
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402975#comment-13402975
]
Robert Muir commented on LUCENE-3832:
-
So how is passing an array of shorts better?
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402979#comment-13402979
]
Dawid Weiss commented on LUCENE-3832:
-
My whining doesn't mean I want to change this
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13219201#comment-13219201
]
Michael McCandless commented on LUCENE-3832:
bq. We should then just move
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218297#comment-13218297
]
Michael McCandless commented on LUCENE-3832:
+1
Then we can remove the class
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218329#comment-13218329
]
Dawid Weiss commented on LUCENE-3832:
-
Huh? Sorry, I don't get you -- what do you
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218338#comment-13218338
]
Uwe Schindler commented on LUCENE-3832:
---
In test-framework is a helper method to
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218341#comment-13218341
]
Michael McCandless commented on LUCENE-3832:
Sorry, what I meant was: we
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218485#comment-13218485
]
Dawid Weiss commented on LUCENE-3832:
-
I don't know if the original version is a
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218880#comment-13218880
]
Robert Muir commented on LUCENE-3832:
-
The version in test-framework was something i
[
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218959#comment-13218959
]
Dawid Weiss commented on LUCENE-3832:
-
We should then just move Robert's port instead
16 matches
Mail list logo
