[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13281700#comment-13281700
]
Uwe Schindler commented on LUCENE-4051:
---
Thank you very much! Now file formats are
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13281338#comment-13281338
]
Robert Muir commented on LUCENE-4051:
-
+1 to commit, thanks for working this! Lets
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280233#comment-13280233
]
Robert Muir commented on LUCENE-4051:
-
javadocs look good: trivial nitpick i noticed
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276566#comment-13276566
]
Robert Muir commented on LUCENE-4051:
-
Patch looks good!
Can you update the
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276617#comment-13276617
]
Simon Willnauer commented on LUCENE-4051:
-
bq. Can you update the fileformat
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274331#comment-13274331
]
Robert Muir commented on LUCENE-4051:
-
One more comment: i think actually we should
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273922#comment-13273922
]
Michael McCandless commented on LUCENE-4051:
+1
Fix File
[
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273953#comment-13273953
]
Robert Muir commented on LUCENE-4051:
-
By the way: we can use CodecUtil.headerLength
