[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793626#comment-13793626
]
Paul Elschot commented on LUCENE-5098:
--
On reviewing the article I found that the
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706697#comment-13706697
]
Dawid Weiss commented on LUCENE-5098:
-
bq. I don't really like using LuceneTestCase
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706750#comment-13706750
]
Dawid Weiss commented on LUCENE-5098:
-
bq. I played a bit with it and rank9 was
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707037#comment-13707037
]
Paul Elschot commented on LUCENE-5098:
--
In the naive implementation above the first
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707191#comment-13707191
]
Dawid Weiss commented on LUCENE-5098:
-
Indeed, it's a regression from an earlier
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707253#comment-13707253
]
Dawid Weiss commented on LUCENE-5098:
-
Looks good to me (there's a likely unused
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707372#comment-13707372
]
ASF subversion and git services commented on LUCENE-5098:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707375#comment-13707375
]
ASF subversion and git services commented on LUCENE-5098:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707384#comment-13707384
]
Adrien Grand commented on LUCENE-5098:
--
Committed. Thanks Paul and Dawid!
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705674#comment-13705674
]
Adrien Grand commented on LUCENE-5098:
--
The patch looks good to me. I'm looking
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705808#comment-13705808
]
Dawid Weiss commented on LUCENE-5098:
-
{code}
TestBroadWord extends TestCase
{code}
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705822#comment-13705822
]
Uwe Schindler commented on LUCENE-5098:
---
bq. Could we extend LuceneTestCase for
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705827#comment-13705827
]
Adrien Grand commented on LUCENE-5098:
--
It does.
Broadword bit
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706160#comment-13706160
]
Paul Elschot commented on LUCENE-5098:
--
bq. Maybe these utility methods could be
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706175#comment-13706175
]
Dawid Weiss commented on LUCENE-5098:
-
bq. I don't really like it, but my next patch
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706215#comment-13706215
]
Paul Elschot commented on LUCENE-5098:
--
I don't really like using LuceneTestCase
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706235#comment-13706235
]
Uwe Schindler commented on LUCENE-5098:
---
You can call {{ant check-forbidden-apis}}
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706372#comment-13706372
]
Adrien Grand commented on LUCENE-5098:
--
bq. A safe conclusion is that moving
[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703649#comment-13703649
]
Paul Elschot commented on LUCENE-5098:
--
This has some methods and constants inspired
19 matches
Mail list logo