[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587921#comment-14587921 ] Alan Woodward commented on LUCENE-6494: --- No reason it can't go in sandbox. I think

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587881#comment-14587881 ] Robert Muir commented on LUCENE-6494: - Again do we really need this stuff in core? Id

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558370#comment-14558370 ] Alan Woodward commented on LUCENE-6494: --- Thanks for dealing with this guys. I've

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554735#comment-14554735 ] David Smiley commented on LUCENE-6494: -- bq. We could add a CollectionTerm to

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554756#comment-14554756 ] Alan Woodward commented on LUCENE-6494: --- Yeah, it's NearSpansOrdered that makes

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554115#comment-14554115 ] Robert Muir commented on LUCENE-6494: - Can we reduce the number of classes here for

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554133#comment-14554133 ] Alan Woodward commented on LUCENE-6494: --- bq. Please use regular names like get()

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555220#comment-14555220 ] Anshum Gupta commented on LUCENE-6494: -- bq. From my perspective that would be ideal,

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555278#comment-14555278 ] Robert Muir commented on LUCENE-6494: - yes, lets leave trunk alone and work out the

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555198#comment-14555198 ] Anshum Gupta commented on LUCENE-6494: -- I didn't really look at the patch but it

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555236#comment-14555236 ] Alan Woodward commented on LUCENE-6494: --- bq. I personally think it makes sense for

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555234#comment-14555234 ] Michael McCandless commented on LUCENE-6494: +1 to make the recent span

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555276#comment-14555276 ] Anshum Gupta commented on LUCENE-6494: -- Sure, I can revert this. Shouldn't we just

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555162#comment-14555162 ] Robert Muir commented on LUCENE-6494: - First of all: thank you very much for

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555205#comment-14555205 ] Robert Muir commented on LUCENE-6494: - From my perspective that would be ideal,

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555229#comment-14555229 ] Robert Muir commented on LUCENE-6494: - I think what is in trunk (LUCENE-6371 and

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555424#comment-14555424 ] Robert Muir commented on LUCENE-6494: - here is my proposed command: {{branch_5x# svn

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555466#comment-14555466 ] ASF subversion and git services commented on LUCENE-6494: - Commit

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555338#comment-14555338 ] Anshum Gupta commented on LUCENE-6494: -- Seems like we'd also need to revert

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555355#comment-14555355 ] Anshum Gupta commented on LUCENE-6494: -- [~rcmuir] if you have time, can you handle

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555406#comment-14555406 ] Robert Muir commented on LUCENE-6494: - OK with me, give me some time and I'll

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555414#comment-14555414 ] Robert Muir commented on LUCENE-6494: - Possibly related:

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555430#comment-14555430 ] Anshum Gupta commented on LUCENE-6494: -- Thanks [~rcmuir]. Looks good to me. I'll be

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555468#comment-14555468 ] Robert Muir commented on LUCENE-6494: - I beasted spans tests 100 times with the

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554547#comment-14554547 ] David Smiley commented on LUCENE-6494: -- I'm looking over your latest patch, with an

[jira] [Commented] (LUCENE-6494) Make PayloadSpanUtil apply to other postings information

[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554587#comment-14554587 ] Alan Woodward commented on LUCENE-6494: --- We could add a CollectionTerm to MatchData