[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022680#comment-15022680
]
ASF subversion and git services commented on LUCENE-6801:
-
Commit 1715911 from
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022640#comment-15022640
]
ASF subversion and git services commented on LUCENE-6801:
-
Commit 1715908 from
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022088#comment-15022088
]
David Smiley commented on LUCENE-6801:
--
I'll commit this in a few hours. It'll be nice to have these
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022767#comment-15022767
]
Adrien Grand commented on LUCENE-6801:
--
I'm a bit late to the party but the change looks good to me
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022275#comment-15022275
]
Jason Gerlowski commented on LUCENE-6801:
-
LGTM
> PhraseQuery incorrectly advertises it supports
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963028#comment-14963028
]
Adrien Grand commented on LUCENE-6801:
--
+1 overall. I'm just bit worried about the following comment
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963309#comment-14963309
]
David Smiley commented on LUCENE-6801:
--
Thanks for the review, Adrien!
RE getPositions: Yes -- it
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963317#comment-14963317
]
David Smiley commented on LUCENE-6801:
--
Cool. I'll commit today.
> PhraseQuery incorrectly
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963315#comment-14963315
]
Adrien Grand commented on LUCENE-6801:
--
Right, this is what I meant. :) So maybe for this method we
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963325#comment-14963325
]
Adrien Grand commented on LUCENE-6801:
--
Oh, I think I just understood the intention of these
[
https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963550#comment-14963550
]
David Smiley commented on LUCENE-6801:
--
Hmm; looks like you're right! Although it's only tested
11 matches
Mail list logo