[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-02-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136136#comment-15136136 ] ASF subversion and git services commented on LUCENE-6930: - Commit

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-02-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135558#comment-15135558 ] ASF subversion and git services commented on LUCENE-6930: - Commit

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-02-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133089#comment-15133089 ] Michael McCandless commented on LUCENE-6930: Patch looks good! If a user accidentally

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-27 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120345#comment-15120345 ] Nicholas Knize commented on LUCENE-6930: Thanks for the feedback [~mikemccand]! I'll post an

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119397#comment-15119397 ] Michael McCandless commented on LUCENE-6930: Thanks [~nknize], this is a nice (and large!)

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118217#comment-15118217 ] Michael McCandless commented on LUCENE-6930: Thanks [~nknize] ... the last patch is a bit

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118227#comment-15118227 ] Michael McCandless commented on LUCENE-6930: Hmm, also a few compilation errors, e.g.:

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-26 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118233#comment-15118233 ] Nicholas Knize commented on LUCENE-6930: argghh.. guessed the fancy {{--show-copies-as-adds}}

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-22 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112630#comment-15112630 ] Nicholas Knize commented on LUCENE-6930: That's unrelated to this patch. Its from nuking the

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112468#comment-15112468 ] Michael McCandless commented on LUCENE-6930: Hmm I'm seeing this test failure with this

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112478#comment-15112478 ] Michael McCandless commented on LUCENE-6930: I think you can attach javadoc to each enum

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112774#comment-15112774 ] Michael McCandless commented on LUCENE-6930: OK, phew! > Decouple GeoPointField from

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-21 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111345#comment-15111345 ] Nicholas Knize commented on LUCENE-6930: It's related to {{TOLERANCE}} and that

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109247#comment-15109247 ] Michael McCandless commented on LUCENE-6930: It's odd that we pass {{GeoPointTermQuery}} down

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106856#comment-15106856 ] Michael McCandless commented on LUCENE-6930: Hmm, the tests pass for me with this patch, but

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-18 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106018#comment-15106018 ] Nicholas Knize commented on LUCENE-6930: Try again with the new patch. I guess diff didn't like

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105986#comment-15105986 ] Michael McCandless commented on LUCENE-6930: Hmm I get compilation errors because things

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-18 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106127#comment-15106127 ] Nicholas Knize commented on LUCENE-6930: Nice!!! Thanks for that protip! That certainly would

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106031#comment-15106031 ] Michael McCandless commented on LUCENE-6930: Thanks [~nknize] If you pass

[jira] [Commented] (LUCENE-6930) Decouple GeoPointField from NumericType

2015-12-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057865#comment-15057865 ] Michael McCandless commented on LUCENE-6930: +1, {{LegacyNumericType}} is now deprecated in