[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101577#comment-15101577
]
Uwe Schindler commented on LUCENE-6973:
---
I checked:
{code:java}
new
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101736#comment-15101736
]
ASF subversion and git services commented on LUCENE-6973:
-
Commit 1724795 from
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101725#comment-15101725
]
Uwe Schindler commented on LUCENE-6973:
---
+1 to commit, only a small change: Use
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101730#comment-15101730
]
ASF subversion and git services commented on LUCENE-6973:
-
Commit 1724789 from
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101750#comment-15101750
]
Uwe Schindler commented on LUCENE-6973:
---
I opened LUCENE-6978 about improving LTC.
> Improve
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101502#comment-15101502
]
Uwe Schindler commented on LUCENE-6973:
---
Hi,
still Javadocs of the default are wrong, it should
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101511#comment-15101511
]
Uwe Schindler commented on LUCENE-6973:
---
Robert had a comment on: LUCENE-4021
> Improve
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101528#comment-15101528
]
Uwe Schindler commented on LUCENE-6973:
---
I tried it: forLanguage tag does not accept "en_US", it
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101551#comment-15101551
]
Robert Muir commented on LUCENE-6973:
-
Try this:
{quote}
If the specified language tag contains any
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101554#comment-15101554
]
Robert Muir commented on LUCENE-6973:
-
and i dont know if that will fix your en_US problem, i think
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101559#comment-15101559
]
Uwe Schindler commented on LUCENE-6973:
---
I also agree that language tag (because they are
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098252#comment-15098252
]
Shai Erera commented on LUCENE-6973:
I think that's ready for commit. [~thetaphi] if you don't have
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098303#comment-15098303
]
Uwe Schindler commented on LUCENE-6973:
---
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097794#comment-15097794
]
Paul Elschot commented on LUCENE-6973:
--
2nd and 3rd patch apply cleanly now, before applying the 2nd
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098394#comment-15098394
]
Uwe Schindler commented on LUCENE-6973:
---
OK looks fine. I did not run tests, I wonder why the tests
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101393#comment-15101393
]
Uwe Schindler commented on LUCENE-6973:
---
Oh missed last comment. Yes will do final review. I agree
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101389#comment-15101389
]
Uwe Schindler commented on LUCENE-6973:
---
Yes, the only way to do this. I think we have a similar
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101399#comment-15101399
]
Uwe Schindler commented on LUCENE-6973:
---
The FilterFactory for the data detection should also list
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098798#comment-15098798
]
Shai Erera commented on LUCENE-6973:
I ran the tests and {{TestRandomChains}} fails with this:
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098278#comment-15098278
]
Uwe Schindler commented on LUCENE-6973:
---
STOP: I think you added some missing TokenFilters to wrong
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098302#comment-15098302
]
Uwe Schindler commented on LUCENE-6973:
---
Can you simple revert the addition of stempel (which is
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096892#comment-15096892
]
Shai Erera commented on LUCENE-6973:
This patch is for trunk. I renamed {{DateRecognizerSinkFilter}}
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096912#comment-15096912
]
Uwe Schindler commented on LUCENE-6973:
---
When you execute svn diff, add the option to show renames
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096958#comment-15096958
]
Paul Elschot commented on LUCENE-6973:
--
With the 2nd patch I get this output:
{noformat}
svn patch
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096886#comment-15096886
]
Paul Elschot commented on LUCENE-6973:
--
The patch has changes to DateRecognizerFilter.java, but I
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096776#comment-15096776
]
Uwe Schindler commented on LUCENE-6973:
---
Hi, I agree with Shai's proposal! So +1 to fix this.
>
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096946#comment-15096946
]
Paul Elschot commented on LUCENE-6973:
--
Ok, somehow I can't cleanly apply the patch, neither with
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096973#comment-15096973
]
Paul Elschot commented on LUCENE-6973:
--
Btw. in case there is preference for ArrayDeque over
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097291#comment-15097291
]
Uwe Schindler commented on LUCENE-6973:
---
bq. Btw. in case there is preference for ArrayDeque over
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094299#comment-15094299
]
Paul Elschot commented on LUCENE-6973:
--
At LUCENE-5687 there is a PrefillTokenStream class that is
[
https://issues.apache.org/jira/browse/LUCENE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094317#comment-15094317
]
Paul Elschot commented on LUCENE-6973:
--
After another look at the code, I think PrefillTokenStream
31 matches
Mail list logo
