[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142802#comment-15142802
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142791#comment-15142791
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142795#comment-15142795
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139702#comment-15139702
]
David Smiley commented on LUCENE-6997:
--
Nick, I have one parting thought before this gets cemented
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139737#comment-15139737
]
Nicholas Knize commented on LUCENE-6997:
+1
bq. With each approach, the Queries can only be used
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140027#comment-15140027
]
David Smiley commented on LUCENE-6997:
--
+1 to the patch. I looked it over quickly and it's of
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140256#comment-15140256
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140264#comment-15140264
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134485#comment-15134485
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134491#comment-15134491
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134477#comment-15134477
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134738#comment-15134738
]
David Smiley commented on LUCENE-6997:
--
+1 looks good to me.
> Graduate GeoUtils and postings based
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134941#comment-15134941
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134800#comment-15134800
]
ASF subversion and git services commented on LUCENE-6997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133327#comment-15133327
]
Uwe Schindler commented on LUCENE-6997:
---
bq. These were actually deliberately changed tab
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133311#comment-15133311
]
Nicholas Knize commented on LUCENE-6997:
Thanks [~steve_rowe]! This is very helpful.
bq. You
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133067#comment-15133067
]
Nicholas Knize commented on LUCENE-6997:
Will do. Based on the discussion right above I created a
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133493#comment-15133493
]
Steve Rowe commented on LUCENE-6997:
Okay, I'll watch LUCENE-7015.
{quote}
bq. ...you didn't modify
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1513#comment-1513
]
Uwe Schindler commented on LUCENE-6997:
---
I know: Only in pom.xml.template files. They are not
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132364#comment-15132364
]
Steve Rowe commented on LUCENE-6997:
Hi Nick, I skimmed the patch and noticed a few things:
* You
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132567#comment-15132567
]
Nicholas Knize commented on LUCENE-6997:
I think that's a great suggestion:
* (This issue / 5.5)
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132581#comment-15132581
]
David Smiley commented on LUCENE-6997:
--
+1 perfect.
> Graduate GeoUtils and postings based
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132550#comment-15132550
]
David Smiley commented on LUCENE-6997:
--
This package reshuffling strikes me as a 6.0 feature; no?
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132772#comment-15132772
]
Michael McCandless commented on LUCENE-6997:
Patch looks nice: I like all the added javadocs,
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123528#comment-15123528
]
Michael McCandless commented on LUCENE-6997:
+1 to graduate the postings based geo impls from
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123704#comment-15123704
]
David Smiley commented on LUCENE-6997:
--
It seems this has more to do with the presence of external
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123714#comment-15123714
]
David Smiley commented on LUCENE-6997:
--
or "lucene-spatial-extras" maybe
> Graduate GeoUtils and
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123897#comment-15123897
]
Nicholas Knize commented on LUCENE-6997:
bq. It seems this has more to do with the presence of
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124422#comment-15124422
]
Michael McCandless commented on LUCENE-6997:
+1 for this plan! I agree we should handle
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124740#comment-15124740
]
Nicholas Knize commented on LUCENE-6997:
+1 as well! A separate issue for geo3d sounds like the
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124042#comment-15124042
]
David Smiley commented on LUCENE-6997:
--
The last 2 bullets are mostly what I meant but the first
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121801#comment-15121801
]
Uwe Schindler commented on LUCENE-6997:
---
bq. I thought Java's module system is changing in Java 9
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121827#comment-15121827
]
Nicholas Knize commented on LUCENE-6997:
Thanks for clearing that up [~thetaphi]!
Then it boils
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121761#comment-15121761
]
Nicholas Knize commented on LUCENE-6997:
bq. What's missing, in your opinion? And did you
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121580#comment-15121580
]
Uwe Schindler commented on LUCENE-6997:
---
What does this have to do with Java 9?
> Graduate
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121593#comment-15121593
]
Uwe Schindler commented on LUCENE-6997:
---
Optional dependencies in Maven have nothing to do with
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121528#comment-15121528
]
David Smiley commented on LUCENE-6997:
--
bq. I agree. While the GeoUtils API is really close to being
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120317#comment-15120317
]
Nicholas Knize commented on LUCENE-6997:
bq. ...can you explain better? I'm unfamiliar with
[
https://issues.apache.org/jira/browse/LUCENE-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120052#comment-15120052
]
David Smiley commented on LUCENE-6997:
--
It's good to see this wonderful work graduating out of
39 matches
Mail list logo
