[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-29 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785476#comment-15785476 ] Paul Elschot commented on LUCENE-7602: -- After taking a closer look at the other issues: How about

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-29 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785307#comment-15785307 ] Paul Elschot commented on LUCENE-7602: -- Looking at that code, the copyOf method should be named

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-29 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785298#comment-15785298 ] Paul Elschot commented on LUCENE-7602: -- For easy reference, ContextMap now looks like this: {code}

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-29 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785283#comment-15785283 ] Paul Elschot commented on LUCENE-7602: -- Thanks for linking to these other issues. > Fix compiler

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-27 Thread Ahmet Arslan (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780903#comment-15780903 ] Ahmet Arslan commented on LUCENE-7602: -- I think the current issue will clean up three previous

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-26 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779059#comment-15779059 ] Paul Elschot commented on LUCENE-7602: -- bq. can't we just use Map ? ContextMap

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-26 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778692#comment-15778692 ] Paul Elschot commented on LUCENE-7602: -- Meanwhile I tried implementing solr's QueryContext by

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-26 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778681#comment-15778681 ] Paul Elschot commented on LUCENE-7602: -- Do you mean like this: {code} public class ContextMap

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-25 Thread Ahmet Arslan (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15777253#comment-15777253 ] Ahmet Arslan commented on LUCENE-7602: -- can't we just use Map instead of Map or

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-25 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15777181#comment-15777181 ] Uwe Schindler commented on LUCENE-7602: --- bq. For solr I have no idea. I would hope that using

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-25 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15776733#comment-15776733 ] Uwe Schindler commented on LUCENE-7602: --- I am so happy that you are interested in fixing the

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-25 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15776698#comment-15776698 ] Paul Elschot commented on LUCENE-7602: -- With both patches applied, ant clean compile-test gives a

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-25 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15776689#comment-15776689 ] Paul Elschot commented on LUCENE-7602: -- The lucene patch replaces the use of IdentityHashMap in

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-25 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15776683#comment-15776683 ] Paul Elschot commented on LUCENE-7602: -- The interesting pieces of code for ContextMap: The class

[jira] [Commented] (LUCENE-7602) Fix compiler warnings for ant clean compile

2016-12-24 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15775468#comment-15775468 ] Paul Elschot commented on LUCENE-7602: -- The patch also contains a few similar fixes for test code,