[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362059#comment-16362059 ] ASF subversion and git services commented on LUCENE-8152: - Commit

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362060#comment-16362060 ] ASF subversion and git services commented on LUCENE-8152: - Commit

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361259#comment-16361259 ] Steve Rowe commented on LUCENE-8152: Starting with the {{aa157f18335}} commit on this issue,

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361043#comment-16361043 ] Adrien Grand commented on LUCENE-8152: -- I'm afraid this will require rewriting upstream history,

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361041#comment-16361041 ] ASF subversion and git services commented on LUCENE-8152: - Commit

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread Horatiu Lazu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360980#comment-16360980 ] Horatiu Lazu commented on LUCENE-8152: -- Hmm. You can amend the author of the last commit I believe,

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360915#comment-16360915 ] Adrien Grand commented on LUCENE-8152: -- Sorry I had not paid attention to the Github PR and took the

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread Horatiu Lazu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360861#comment-16360861 ] Horatiu Lazu commented on LUCENE-8152: -- Thanks, is it possible to have accepted my pull request on

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360796#comment-16360796 ] ASF subversion and git services commented on LUCENE-8152: - Commit

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-05 Thread Horatiu Lazu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352738#comment-16352738 ] Horatiu Lazu commented on LUCENE-8152: -- Okay, thanks! > Simplify conditionals in JoinUtil >

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352391#comment-16352391 ] Adrien Grand commented on LUCENE-8152: -- This looks good at first sight. I'll run tests to confirm.

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-02 Thread Horatiu Lazu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351246#comment-16351246 ] Horatiu Lazu commented on LUCENE-8152: -- I added changes throughout the codebase, hope this is good.

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350439#comment-16350439 ] Adrien Grand commented on LUCENE-8152: -- That would be great. > Simplify conditionals in JoinUtil >

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-02 Thread Horatiu Lazu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350370#comment-16350370 ] Horatiu Lazu commented on LUCENE-8152: -- Yes, I'll change them tonight. Should I do it in this patch?

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-02 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350317#comment-16350317 ] Martijn van Groningen commented on LUCENE-8152: --- +1 That is much cleaner > Simplify

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350288#comment-16350288 ] Adrien Grand commented on LUCENE-8152: -- Your patch looks good to me. Would you like to change the

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-01 Thread Horatiu Lazu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349753#comment-16349753 ] Horatiu Lazu commented on LUCENE-8152: -- Similar patterns seem to exist in other parts of the code,