[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[
https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493017#comment-16493017
]
Lucene/Solr QA commented on LUCENE-8334:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} LUCENE-8334 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/lucene-java/HowToContribute#Contributing_your_work for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8334 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12925386/LUCENE-8334.patch |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/19/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Ensure SR#getSementInfo() returns snapshot
> --
>
> Key: LUCENE-8334
> URL: https://issues.apache.org/jira/browse/LUCENE-8334
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 7.4, master (8.0)
>Reporter: Simon Willnauer
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8334.patch, LUCENE-8334.patch
>
>
> The SegmentCommitInfo passed to the segment reader is mutated concurrently.
> An instance obtained from SR#getSegmentInfo() might return wrong delete
> counts
> or generation ids. This ensures that the SR will use a clone internally
> while stil
> maintaining the original SI since it's needed inside IW for maintainance
> like
> accessing pooled readers etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[ https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492615#comment-16492615 ] ASF subversion and git services commented on LUCENE-8334: - Commit b918ee8fe69a5cb0323ca8a842149fde55e09411 in lucene-solr's branch refs/heads/branch_7x from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b918ee8 ] LUCENE-8334: Ensure SR#getSementInfo() returns snapshot The SegmentCommitInfo passed to the segment reader is mutated concurrently. An instance obtained from SR#getSegmentInfo() might return wrong delete counts or generation ids. This ensures that the SR will use a clone internally while stil maintaining the original SI since it's needed inside IW for maintainance like accessing pooled readers etc. > Ensure SR#getSementInfo() returns snapshot > -- > > Key: LUCENE-8334 > URL: https://issues.apache.org/jira/browse/LUCENE-8334 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8334.patch, LUCENE-8334.patch > > > The SegmentCommitInfo passed to the segment reader is mutated concurrently. > An instance obtained from SR#getSegmentInfo() might return wrong delete > counts > or generation ids. This ensures that the SR will use a clone internally > while stil > maintaining the original SI since it's needed inside IW for maintainance > like > accessing pooled readers etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[ https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492611#comment-16492611 ] ASF subversion and git services commented on LUCENE-8334: - Commit 0941cae532ddf7b9af3df55c63941f547c769108 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0941cae ] LUCENE-8334: Ensure SR#getSementInfo() returns snapshot The SegmentCommitInfo passed to the segment reader is mutated concurrently. An instance obtained from SR#getSegmentInfo() might return wrong delete counts or generation ids. This ensures that the SR will use a clone internally while stil maintaining the original SI since it's needed inside IW for maintainance like accessing pooled readers etc. > Ensure SR#getSementInfo() returns snapshot > -- > > Key: LUCENE-8334 > URL: https://issues.apache.org/jira/browse/LUCENE-8334 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8334.patch, LUCENE-8334.patch > > > The SegmentCommitInfo passed to the segment reader is mutated concurrently. > An instance obtained from SR#getSegmentInfo() might return wrong delete > counts > or generation ids. This ensures that the SR will use a clone internally > while stil > maintaining the original SI since it's needed inside IW for maintainance > like > accessing pooled readers etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[ https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492507#comment-16492507 ] Simon Willnauer commented on LUCENE-8334: - alright cool, no I just made the ctor pkg private. > Ensure SR#getSementInfo() returns snapshot > -- > > Key: LUCENE-8334 > URL: https://issues.apache.org/jira/browse/LUCENE-8334 > Project: Lucene - Core > Issue Type: Bug >Reporter: Simon Willnauer >Priority: Major > Attachments: LUCENE-8334.patch > > > The SegmentCommitInfo passed to the segment reader is mutated concurrently. > An instance obtained from SR#getSegmentInfo() might return wrong delete > counts > or generation ids. This ensures that the SR will use a clone internally > while stil > maintaining the original SI since it's needed inside IW for maintainance > like > accessing pooled readers etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[ https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492502#comment-16492502 ] Dawid Weiss commented on LUCENE-8334: - Yeah... I look as much as my time permits, which isn't too much. :( What you mention is actually what we do: I wrongly thought you removed the public qualifier from the class (as well as the constructor); looking at the diff only confused me. LGTM! > Ensure SR#getSementInfo() returns snapshot > -- > > Key: LUCENE-8334 > URL: https://issues.apache.org/jira/browse/LUCENE-8334 > Project: Lucene - Core > Issue Type: Bug >Reporter: Simon Willnauer >Priority: Major > Attachments: LUCENE-8334.patch > > > The SegmentCommitInfo passed to the segment reader is mutated concurrently. > An instance obtained from SR#getSegmentInfo() might return wrong delete > counts > or generation ids. This ensures that the SR will use a clone internally > while stil > maintaining the original SI since it's needed inside IW for maintainance > like > accessing pooled readers etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[ https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492496#comment-16492496 ] Simon Willnauer commented on LUCENE-8334: - [~dweiss] I am glad you checking stuff out here. I did look and I wonder why you can't just open the index you need from a directory and then steal the SegmentReader from it's leaves? I can totally back this part out and open another issue to discuss it, just asking to understand why there is no alternative? > Ensure SR#getSementInfo() returns snapshot > -- > > Key: LUCENE-8334 > URL: https://issues.apache.org/jira/browse/LUCENE-8334 > Project: Lucene - Core > Issue Type: Bug >Reporter: Simon Willnauer >Priority: Major > Attachments: LUCENE-8334.patch > > > The SegmentCommitInfo passed to the segment reader is mutated concurrently. > An instance obtained from SR#getSegmentInfo() might return wrong delete > counts > or generation ids. This ensures that the SR will use a clone internally > while stil > maintaining the original SI since it's needed inside IW for maintainance > like > accessing pooled readers etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8334) Ensure SR#getSementInfo() returns snapshot
[
https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492348#comment-16492348
]
Dawid Weiss commented on LUCENE-8334:
-
Hi Simon. This was made private in this patch:
{code}
- // TODO: why is this public?
- public SegmentReader(SegmentCommitInfo si, int createdVersionMajor,
IOContext context) throws IOException {
-this.si = si;
+ SegmentReader(SegmentCommitInfo si, int createdVersionMajor, IOContext
context) throws IOException {
{code}
I agree it's expert-level API, but it is useful (has no alternative) for
manipulating parallel indexes (see TestDemoParallelLeafReader). I am actually
using this stuff (outside of Lucene code) exactly like Mike's "demo" shows --
to maintain derived indexes from primary segments.
Can we make a primary API citizen (or expose a public interface implemented by
this class that would convey the information required for
TestDemoParallelLeafReader to work, if it's moved from .index package)?
> Ensure SR#getSementInfo() returns snapshot
> --
>
> Key: LUCENE-8334
> URL: https://issues.apache.org/jira/browse/LUCENE-8334
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Simon Willnauer
>Priority: Major
> Attachments: LUCENE-8334.patch
>
>
> The SegmentCommitInfo passed to the segment reader is mutated concurrently.
> An instance obtained from SR#getSegmentInfo() might return wrong delete
> counts
> or generation ids. This ensures that the SR will use a clone internally
> while stil
> maintaining the original SI since it's needed inside IW for maintainance
> like
> accessing pooled readers etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
