[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860026#comment-16860026
]
Atri Sharma commented on LUCENE-8362:
-
Thanks for pushing this, Adrien!
> Add DocValue support for
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860022#comment-16860022
]
ASF subversion and git services commented on LUCENE-8362:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859988#comment-16859988
]
Adrien Grand commented on LUCENE-8362:
--
FYI I slightly modified your patch to give range values a
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859985#comment-16859985
]
ASF subversion and git services commented on LUCENE-8362:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859884#comment-16859884
]
Atri Sharma commented on LUCENE-8362:
-
Thanks Adrien, attached is an updated patch
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859854#comment-16859854
]
Adrien Grand commented on LUCENE-8362:
--
Thanks Atri, this looks good in general. I only spotted one
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859796#comment-16859796
]
Atri Sharma commented on LUCENE-8362:
-
Some minor test formatting cleanups
[^LUCENE-8362.patch]
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858906#comment-16858906
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Please let me know if the latest iteration needs
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857406#comment-16857406
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Sure, does attached look fine?
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857376#comment-16857376
]
Adrien Grand commented on LUCENE-8362:
--
Could we move it to the same package as
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857363#comment-16857363
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Thanks, attached is an updated patch.
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857035#comment-16857035
]
Adrien Grand commented on LUCENE-8362:
--
This looks good in general, some minor comments:
- tests
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856693#comment-16856693
]
Atri Sharma commented on LUCENE-8362:
-
Thanks Adrien!
> Add DocValue support for RangeFields
>
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856672#comment-16856672
]
Adrien Grand commented on LUCENE-8362:
--
I'll have a look today.
> Add DocValue support for
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856668#comment-16856668
]
Atri Sharma commented on LUCENE-8362:
-
Does this patch look like in a commitable shape now? Anything
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855680#comment-16855680
]
Atri Sharma commented on LUCENE-8362:
-
I have opened up a follow up Jira for the follow up:
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855465#comment-16855465
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Thanks, attached is an updated patch.
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855432#comment-16855432
]
Adrien Grand commented on LUCENE-8362:
--
Thanks [~atris] I like how this is structured in general.
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855400#comment-16855400
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Another thought, BTW. Given how the patch is
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852087#comment-16852087
]
Atri Sharma commented on LUCENE-8362:
-
[~mgrigorov] No specific reason. I am accustomed to patches
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852082#comment-16852082
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Thanks for the comments. Attached is an updated
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851628#comment-16851628
]
Martin Grigorov commented on LUCENE-8362:
-
[~atris] Off Topic: Why do you prefer working with
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850577#comment-16850577
]
Adrien Grand commented on LUCENE-8362:
--
Thanks Atri. I missed the part about "exactly match" in
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850544#comment-16850544
]
Atri Sharma commented on LUCENE-8362:
-
[^LUCENE-8362.patch]
[~jpountz] Attached is an updated
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849507#comment-16849507
]
Adrien Grand commented on LUCENE-8362:
--
This would be the right implementation indeed!
> Add
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849498#comment-16849498
]
Atri Sharma commented on LUCENE-8362:
-
[~jpountz] Thanks for your comments.
I wanted to check
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849445#comment-16849445
]
Adrien Grand commented on LUCENE-8362:
--
I had a quick look. The code organization looks good in
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849340#comment-16849340
]
Atri Sharma commented on LUCENE-8362:
-
[^LUCENE-8362.patch]
Hi [~jpountz]
Thanks for your
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848917#comment-16848917
]
Adrien Grand commented on LUCENE-8362:
--
I like the approach, I'd just reduce visibility of new code
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848898#comment-16848898
]
Atri Sharma commented on LUCENE-8362:
-
[^LUCENE-8362-approach2.patch]
Hi [~jpountz],
Thanks
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845816#comment-16845816
]
Adrien Grand commented on LUCENE-8362:
--
I agree this could be useful in conjunction with
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845725#comment-16845725
]
Atri Sharma commented on LUCENE-8362:
-
Could we move ahead with this? This seems like a simple
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839614#comment-16839614
]
Atri Sharma commented on LUCENE-8362:
-
Attached is a patch for implementing this.
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518254#comment-16518254
]
David Smiley commented on LUCENE-8362:
--
This would be a nice convenience. Today, two Fields are
34 matches
Mail list logo
