[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719272#comment-16719272 ] Christophe Bismuth commented on LUCENE-8464: Thanks a lot [~romseygeek], you made my day :D [~jim.ferenczi] has made some really great mentoring with me on this one (y) I hope to find some other great issues to work on! > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Fix For: master (8.0) > > Time Spent: 8h > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719100#comment-16719100 ] Alan Woodward commented on LUCENE-8464: --- [~cbismuth] thought you'd like to know that this looks to have made an impressive change to the performance of Wildcard and Prefix queries. Nicely done! [https://home.apache.org/~mikemccand/lucenebench/Wildcard.html] [https://home.apache.org/~mikemccand/lucenebench/Prefix3.html] > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Fix For: master (8.0) > > Time Spent: 8h > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693359#comment-16693359 ] ASF subversion and git services commented on LUCENE-8464: - Commit 759af0127cb1d12a89162361f6377a71774254dc in lucene-solr's branch refs/heads/jira/http2 from [~jim.ferenczi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=759af01 ] LUCENE-8464: Fix legacy.TestMultiValuedNumericRangeQuery to count the number of hits accurately > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Fix For: master (8.0) > > Time Spent: 8h > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691401#comment-16691401 ] ASF subversion and git services commented on LUCENE-8464: - Commit 759af0127cb1d12a89162361f6377a71774254dc in lucene-solr's branch refs/heads/master from [~jim.ferenczi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=759af01 ] LUCENE-8464: Fix legacy.TestMultiValuedNumericRangeQuery to count the number of hits accurately > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Fix For: master (8.0) > > Time Spent: 7h 50m > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689497#comment-16689497 ] Christophe Bismuth commented on LUCENE-8464: Thank you [~jim.ferenczi], it was a great experience (y) > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Fix For: master (8.0) > > Time Spent: 7h 50m > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689457#comment-16689457 ] ASF subversion and git services commented on LUCENE-8464: - Commit b4449c73e4c1ed34bc155ae5a818ac1a870ea7f8 in lucene-solr's branch refs/heads/master from [~cbismuth] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b4449c7 ] LUCENE-8464: ConstantScoreScorer now implements setMinCompetitveScore in order to early terminate the iterator if the minimum score is greater than the constant score. Signed-off-by: Jim Ferenczi > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Time Spent: 7h 50m > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680002#comment-16680002 ] Christophe Bismuth commented on LUCENE-8464: Hi, I've opened PR [#495|https://github.com/apache/lucene-solr/pull/495] on GitHub to implement this, could you please tell me if this implementation could fit? Thank you. > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Time Spent: 10m > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680072#comment-16680072 ] Jim Ferenczi commented on LUCENE-8464: -- Thanks [~cbismuth], I added some comments on the github issue > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > Time Spent: 50m > Remaining Estimate: 0h > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore
[ https://issues.apache.org/jira/browse/LUCENE-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678314#comment-16678314 ] Christophe Bismuth commented on LUCENE-8464: Hi, I'd like to work on this one. > Implement ConstantScoreScorer#setMinCompetitiveScore > > > Key: LUCENE-8464 > URL: https://issues.apache.org/jira/browse/LUCENE-8464 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Labels: newdev > > We should make it so the iterator returns NO_MORE_DOCS after > setMinCompetitiveScore is called with a value that is greater than the > constant score. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
