[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705082#comment-16705082
]
Namgyu Kim commented on LUCENE-8575:
Thanks for applying my code, [~jpountz] :D
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Fix For: master (8.0), 7.7
>
> Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704435#comment-16704435
]
ASF subversion and git services commented on LUCENE-8575:
-
Commit 8c4c3cffa388a3289037b67b8aeafa5d727e98f4 in lucene-solr's branch
refs/heads/branch_7x from [~danmuzi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8c4c3cf ]
LUCENE-8575: Improve toString() in SegmentInfo
Signed-off-by: Namgyu Kim
Signed-off-by: Adrien Grand
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704437#comment-16704437
]
ASF subversion and git services commented on LUCENE-8575:
-
Commit c2ab04775dd2b683f96e65c78a7a3696396d2263 in lucene-solr's branch
refs/heads/master from [~danmuzi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c2ab047 ]
LUCENE-8575: Improve toString() in SegmentInfo
Signed-off-by: Namgyu Kim
Signed-off-by: Adrien Grand
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704322#comment-16704322
]
Lucene/Solr QA commented on LUCENE-8575:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 27m
52s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
50s{color} | {color:green} test-framework in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8575 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12949850/LUCENE-8575.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 75b1831 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/128/testReport/ |
| modules | C: lucene/core lucene/test-framework U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/128/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail:
[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703836#comment-16703836
]
Adrien Grand commented on LUCENE-8575:
--
Thanks [~danmuzi], it looks good to me! I'll merge tomorrow.
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701982#comment-16701982
]
Namgyu Kim commented on LUCENE-8575:
Thank you for your reply, [~jpountz] :D
I uploaded a new patch that reflected your opinion.
before:
TEST(8.0.0):C1:[indexSort=]:[diagnostics=,]:[attributes=,]
after :
TEST(8.0.0):C1:[indexSort=]:[diagnostics=\{key1=value1,
key2=value2}]:[attributes=\{key1=value1, key2=value2}]
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8575) Improve toString() in SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701886#comment-16701886
]
Adrien Grand commented on LUCENE-8575:
--
Thanks [~danmuzi]. Let's reuse attributes.toString() and diagnostics.toString()
instead of reimplementing Map#toString?
> Improve toString() in SegmentInfo
> -
>
> Key: LUCENE-8575
> URL: https://issues.apache.org/jira/browse/LUCENE-8575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Namgyu Kim
>Priority: Major
> Attachments: LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
> StringBuilder s = new StringBuilder();
> s.append(name).append('(').append(version == null ? "?" :
> version).append(')').append(':');
> char cfs = getUseCompoundFile() ? 'c' : 'C';
> s.append(cfs);
> s.append(maxDoc);
> if (delCount != 0) {
> s.append('/').append(delCount);
> }
> if (indexSort != null) {
> s.append(":[indexSort=");
> s.append(indexSort);
> s.append(']');
> }
> // New Code
> if (!diagnostics.isEmpty()) {
> s.append(":[diagnostics=");
> for (Map.Entry entry : diagnostics.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> // New Code
> if (!attributes.isEmpty()) {
> s.append(":[attributes=");
> for (Map.Entry entry : attributes.entrySet())
>
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
> s.setLength(s.length() - 1);
> s.append(']');
> }
> return s.toString();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
