[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-12 Thread Zsolt Gyulavari (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718962#comment-16718962 ] Zsolt Gyulavari commented on LUCENE-8587: - [~kwri...@metacarta.com] as kind of an afterthought,

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717995#comment-16717995 ] ASF subversion and git services commented on LUCENE-8587: - Commit

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Zsolt Gyulavari (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717841#comment-16717841 ] Zsolt Gyulavari commented on LUCENE-8587: - Thanks [~kwri...@metacarta.com] for the quick

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717747#comment-16717747 ] ASF subversion and git services commented on LUCENE-8587: - Commit

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717619#comment-16717619 ] Erick Erickson commented on LUCENE-8587: Zsolt: Yes, upload a new patch. Note the name should

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Zsolt Gyulavari (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717617#comment-16717617 ] Zsolt Gyulavari commented on LUCENE-8587: - Thank you [~ivera] and [~kwri...@metacarta.com] for

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717269#comment-16717269 ] ASF subversion and git services commented on LUCENE-8587: - Commit

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717159#comment-16717159 ] Karl Wright commented on LUCENE-8587: - Thinking about it, it seems safest to me to serialize and

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717068#comment-16717068 ] Karl Wright commented on LUCENE-8587: - It appears GeoStandardCircle and GeoExactCircle require

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717035#comment-16717035 ] Karl Wright commented on LUCENE-8587: - What I'd like to do is change the GeoPoint serialization and

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717020#comment-16717020 ] Karl Wright commented on LUCENE-8587: - Ok, you're right, this is more complex. We cannot do without

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717004#comment-16717004 ] Karl Wright commented on LUCENE-8587: - {quote} Maybe we should build the point here using the

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-11 Thread Ignacio Vera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716492#comment-16716492 ] Ignacio Vera commented on LUCENE-8587: -- I think the problems comes from how the testPoint is

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-10 Thread Zsolt Gyulavari (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715216#comment-16715216 ] Zsolt Gyulavari commented on LUCENE-8587: - Apparently I've tapped in a bigger question here.

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-05 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710721#comment-16710721 ] Lucene/Solr QA commented on LUCENE-8587: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-03 Thread Zsolt Gyulavari (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707481#comment-16707481 ] Zsolt Gyulavari commented on LUCENE-8587: - Original commit in GitHub here:

[jira] [Commented] (LUCENE-8587) Self comparison bug in GeoComplexPolygon.equals method

2018-12-03 Thread Zsolt Gyulavari (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707424#comment-16707424 ] Zsolt Gyulavari commented on LUCENE-8587: - Hi All, Please review this patch. > Self comparison