[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734555#comment-16734555
]
Lucene/Solr QA commented on LUCENE-8601:
| (x) *{color:red}-1 overall{color}* |
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734391#comment-16734391
]
ASF subversion and git services commented on LUCENE-8601:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734103#comment-16734103
]
Michael McCandless commented on LUCENE-8601:
Thanks [~muralikpbhat] – I'll r
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734046#comment-16734046
]
Murali Krishna P commented on LUCENE-8601:
--
Thanks [~mikemccand]. Uploaded a se
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733641#comment-16733641
]
Michael McCandless commented on LUCENE-8601:
Hi [~muralikpbhat], I pushed th
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733635#comment-16733635
]
ASF subversion and git services commented on LUCENE-8601:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731696#comment-16731696
]
Michael McCandless commented on LUCENE-8601:
Thanks I will review and push s
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731626#comment-16731626
]
Lucene/Solr QA commented on LUCENE-8601:
| (/) *{color:green}+1 overall{color}*
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731518#comment-16731518
]
Murali Krishna P commented on LUCENE-8601:
--
Thanks, Added java docs for ignoreC
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731288#comment-16731288
]
Michael McCandless commented on LUCENE-8601:
Ahh OK thanks [~muralikpbhat];
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730866#comment-16730866
]
Murali Krishna P commented on LUCENE-8601:
--
Thanks Mike,
regarding the asserti
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730210#comment-16730210
]
Michael McCandless commented on LUCENE-8601:
Thanks [~muralikpbhat]!
Maybe
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730028#comment-16730028
]
Murali Krishna P commented on LUCENE-8601:
--
[^LUCENE-8601.05.patch] which retai
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729119#comment-16729119
]
Lucene/Solr QA commented on LUCENE-8601:
| (/) *{color:green}+1 overall{color}*
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728862#comment-16728862
]
Murali Krishna P commented on LUCENE-8601:
--
You are right, [~mikemccand]. The F
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725297#comment-16725297
]
Michael McCandless commented on LUCENE-8601:
Hmm, I'm concerned that segment
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725251#comment-16725251
]
Michael McCandless commented on LUCENE-8601:
Thanks [~muralikpbhat]; new pat
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724142#comment-16724142
]
Lucene/Solr QA commented on LUCENE-8601:
| (/) *{color:green}+1 overall{color}*
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723651#comment-16723651
]
Murali Krishna P commented on LUCENE-8601:
--
Good catch [~jpountz], fixed it and
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723036#comment-16723036
]
Adrien Grand commented on LUCENE-8601:
--
Should the copy constructor of FieldType cl
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723009#comment-16723009
]
Michael McCandless commented on LUCENE-8601:
Thanks [~muralikpbhat]; new pat
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722961#comment-16722961
]
Murali Krishna P commented on LUCENE-8601:
--
Done that change [^LUCENE-8601.03.p
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722893#comment-16722893
]
Michael McCandless commented on LUCENE-8601:
Thanks [~muralikpbhat]; can we
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722670#comment-16722670
]
Murali Krishna P commented on LUCENE-8601:
--
Thanks [~mikemccand] for reviewing.
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721504#comment-16721504
]
Michael McCandless commented on LUCENE-8601:
Patch looks great [~muralikpbha
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719896#comment-16719896
]
Murali Krishna P commented on LUCENE-8601:
--
Lucene precommit Jenkins seems to b
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718913#comment-16718913
]
Murali Krishna P commented on LUCENE-8601:
--
Fixed the failing test and solr.
>
[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716998#comment-16716998
]
Lucene/Solr QA commented on LUCENE-8601:
| (x) *{color:red}-1 overall{color}* |
28 matches
Mail list logo
