[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-04-15 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818266#comment-16818266 ] Mike Sokolov commented on LUCENE-8681: -- I updated the PR with a new patch that changes the API for

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-19 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771986#comment-16771986 ] Mike Sokolov commented on LUCENE-8681: -- I posted [a new

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-15 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769854#comment-16769854 ] Mike Sokolov commented on LUCENE-8681: -- bq. ... doMaxScore and trackTotalHits (did you mean

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-15 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769792#comment-16769792 ] Robert Muir commented on LUCENE-8681: - I agree with the first suggestion, too. Let's put it beside

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-15 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769698#comment-16769698 ] Mike Sokolov commented on LUCENE-8681: -- There are a bunch of different ways to provide for opt-in

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-13 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767360#comment-16767360 ] Mike Sokolov commented on LUCENE-8681: -- Yes, I guess it would be necessary to pass a

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766692#comment-16766692 ] Robert Muir commented on LUCENE-8681: - As far as tests, I agree, yes lets not swap in any inexact

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-12 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766112#comment-16766112 ] Mike Sokolov commented on LUCENE-8681: -- bq. so from my perspective, api change is not really crazy

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765654#comment-16765654 ] Robert Muir commented on LUCENE-8681: - also unrelated to any user concern, we have to address

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765645#comment-16765645 ] Robert Muir commented on LUCENE-8681: - {quote} The point of the math above is that we can bound the

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-09 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764163#comment-16764163 ] Mike Sokolov commented on LUCENE-8681: -- I hope I'm not reading this the right way (?!? :), but I do

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762679#comment-16762679 ] Robert Muir commented on LUCENE-8681: - Please don't read this the right way, but this is

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-07 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762656#comment-16762656 ] Mike Sokolov commented on LUCENE-8681: -- bq. However I wonder if this could be implemented directly

[jira] [Commented] (LUCENE-8681) Prorated early termination

2019-02-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761583#comment-16761583 ] Jim Ferenczi commented on LUCENE-8681: -- For the normal case where a single top docs collector is