[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800176#comment-16800176
]
Noble Paul commented on LUCENE-8725:
[~romseygeek] Shall I change this ticket to make {{SeekingTermSetTermsEnum}}
public and fix this?
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793420#comment-16793420
]
Adrien Grand commented on LUCENE-8725:
--
I think it was done this way to make sure that equals/hashCode remain fast,
since the query cache calls these methods implicitly quite frequently. If we
were to do this again today, maybe we'd consider disabling caching instead
(Weight#isCacheable).
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793005#comment-16793005
]
Noble Paul commented on LUCENE-8725:
bq. Is my assumption correct that you are interested in this query because you
don't want to copy the content of the BytesRefHash and because your query might
match most of the ids that exist in the index?
Yes, correct.
bq. Maybe the one piece that we can make public somewhere is the
SeekingTermSetTermsEnum?
Yes, this should be enough, because most of the heavy lifting is done there .
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793009#comment-16793009
]
Noble Paul commented on LUCENE-8725:
bq.This query is cheating a bit in its equals/hashCode to be cacheable without
having to actually compare the BytesRefHash by comparing the join query,
True. I wonder why it was done that way
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792478#comment-16792478
]
Adrien Grand commented on LUCENE-8725:
--
Is my assumption correct that you are interested in this query because you
don't want to copy the content of the BytesRefHash and because your query might
match most of the ids that exist in the index?
This query is cheating a bit in its equals/hashCode to be cacheable without
having to actually compare the BytesRefHash by comparing the join query, the
join field and the index it has been generated on instead. In my opinion it'd
be better to fork the query. Maybe the one piece that we can make public
somewhere is the SeekingTermSetTermsEnum?
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792129#comment-16792129
]
Noble Paul commented on LUCENE-8725:
The constructor
{code}
TermsQuery(String toField, BytesRefHash terms, String fromField, Query
fromQuery, Object indexReaderContextId)
{code}
is particularly helpful for my use-case
What alternative do I have if I have my terms already in a {{BytesRefHash}} ?
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8725) Make TermsQuery public
[
https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792118#comment-16792118
]
Alan Woodward commented on LUCENE-8725:
---
Can you use TermInSetQuery instead? In fact, I think we can probably remove
TermsQuery entirely - it dates from when TermInSetQuery wasn't in core, and so
couldn't be used by the join module.
> Make TermsQuery public
> --
>
> Key: LUCENE-8725
> URL: https://issues.apache.org/jira/browse/LUCENE-8725
> Project: Lucene - Core
> Issue Type: Wish
>Reporter: Noble Paul
>Priority: Trivial
> Fix For: 8.1
>
>
> I have come across use-cases where directly accessing {{TermsQuery}} can
> help. If there is no objection I would like to make it public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
