[jira] [Commented] (LUCENE-8749) Proposal: Pluggable Interface for Slice Allocation Algorithm

2019-04-07 Thread Atri Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811802#comment-16811802
 ] 

Atri Sharma commented on LUCENE-8749:
-

Agreed, a better IndexSearcher#slices implementation would definitely help.

 

However, I believe that the ability to customize the method through an external 
object allows a user more granular control over the slice allocation algorithm. 
Two users might have wildly different parameters on which they want to allocate 
slices, so drawing a best fit algorithm for both of them might be hard.

 

I believe that having both the functionalities is a good idea. I am happy to 
open another Jira for tracking efforts on a better default slice allocation 
algorithm.

 

Thoughts?

> Proposal: Pluggable Interface for Slice Allocation Algorithm
> 
>
> Key: LUCENE-8749
> URL: https://issues.apache.org/jira/browse/LUCENE-8749
> Project: Lucene - Core
>  Issue Type: Improvement
>  Components: core/search
>Reporter: Atri Sharma
>Priority: Major
>
> The slice allocation method allocates one thread per segment today. If a user 
> wishes to use a different slice allocation algorithm, there is no way except 
> to make a change in IndexSearcher. This Jira proposes an interface to 
> decouple the slice allocation mechanism from IndexSearcher and allow plugging 
> in the method from an external factory (like Collectors).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8749) Proposal: Pluggable Interface for Slice Allocation Algorithm

2019-04-05 Thread Adrien Grand (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810987#comment-16810987
 ] 

Adrien Grand commented on LUCENE-8749:
--

I'm wondering whether customizing slices would actually be necessary if we had 
a better default implementation of IndexSearcher#slices? For instance something 
that would create slices of similar sizes?

> Proposal: Pluggable Interface for Slice Allocation Algorithm
> 
>
> Key: LUCENE-8749
> URL: https://issues.apache.org/jira/browse/LUCENE-8749
> Project: Lucene - Core
>  Issue Type: Improvement
>  Components: core/search
>Reporter: Atri Sharma
>Priority: Major
>
> The slice allocation method allocates one thread per segment today. If a user 
> wishes to use a different slice allocation algorithm, there is no way except 
> to make a change in IndexSearcher. This Jira proposes an interface to 
> decouple the slice allocation mechanism from IndexSearcher and allow plugging 
> in the method from an external factory (like Collectors).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org