[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920375#comment-16920375
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920374#comment-16920374
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899643#comment-16899643
]
Tomoko Uchida commented on LUCENE-8778:
---
Here is an additional patch for updating MIGRATE.txt:
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899642#comment-16899642
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885969#comment-16885969
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883473#comment-16883473
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883044#comment-16883044
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883028#comment-16883028
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883017#comment-16883017
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870301#comment-16870301
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870231#comment-16870231
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870228#comment-16870228
]
Tomoko Uchida commented on LUCENE-8778:
---
I also pushed same changes to 8.x branch, because it
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870226#comment-16870226
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870227#comment-16870227
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870224#comment-16870224
]
Tomoko Uchida commented on LUCENE-8778:
---
I was not aware that a new token filter
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870223#comment-16870223
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870008#comment-16870008
]
ASF subversion and git services commented on LUCENE-8778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848292#comment-16848292
]
Tomoko Uchida commented on LUCENE-8778:
---
Sorry, here is the diff between the master and my branch
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848225#comment-16848225
]
Tomoko Uchida commented on LUCENE-8778:
---
I updated the pull request.
* Service lookup is
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848181#comment-16848181
]
Tomoko Uchida commented on LUCENE-8778:
---
Thanks for the comment, I will rethink the implementation
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848161#comment-16848161
]
Uwe Schindler commented on LUCENE-8778:
---
Instead of slowing down the case-insensitive lookup, I'd
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848148#comment-16848148
]
Tomoko Uchida commented on LUCENE-8778:
---
Or, we may be able to document about the case-insensitive
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848132#comment-16848132
]
Tomoko Uchida commented on LUCENE-8778:
---
bq. Now documented SPI names are camel cased, so it would
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847486#comment-16847486
]
Tomoko Uchida commented on LUCENE-8778:
---
Hi [~thetaphi],
I did a regression test and fixed
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846110#comment-16846110
]
Uwe Schindler commented on LUCENE-8778:
---
Hi Tomoko, from my persepctive this looks fine.
> Define
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846037#comment-16846037
]
Tomoko Uchida commented on LUCENE-8778:
---
Update: static SPI {{NAME}} fields and javadoc tags are
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832463#comment-16832463
]
Uwe Schindler commented on LUCENE-8778:
---
Comments are now there. I fogot to click on "Start
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830829#comment-16830829
]
Tomoko Uchida commented on LUCENE-8778:
---
Hi Uwe,
seems your comments are not visible to me. Not
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830689#comment-16830689
]
Uwe Schindler commented on LUCENE-8778:
---
I added some review comments. Looks fine to me, I just
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830626#comment-16830626
]
Tomoko Uchida commented on LUCENE-8778:
---
Hi Uwe,
I updated the pull request:
* Now
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826897#comment-16826897
]
Tomoko Uchida commented on LUCENE-8778:
---
Thanks,
first I thought we can change the SPI loader in
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826852#comment-16826852
]
Uwe Schindler commented on LUCENE-8778:
---
Hi Tomoko,
the first step looks fine. But now we have 2
[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826254#comment-16826254
]
Tomoko Uchida commented on LUCENE-8778:
---
To begin with, I only changed char filters for design
33 matches
Mail list logo
