[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-19 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867977#comment-16867977 ] Mike Sokolov commented on LUCENE-8816: -- LUCENE-8871 opened to cover moving dictiona

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-19 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867793#comment-16867793 ] Tomoko Uchida commented on LUCENE-8816: --- I opened LUCENE-8869 to just decouple the

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-15 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864672#comment-16864672 ] Mike Sokolov commented on LUCENE-8816: -- I opened LUCENE-8863 to cover some small, b

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-11 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861672#comment-16861672 ] Tomoko Uchida commented on LUCENE-8816: --- I'd like to add some more information: th

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-11 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861622#comment-16861622 ] Mike Sokolov commented on LUCENE-8816: -- Thanks Robert, yeah I understand this was b

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861618#comment-16861618 ] Robert Muir commented on LUCENE-8816: - Mike: yes, I agree with you. The use of asser

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-11 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861609#comment-16861609 ] Mike Sokolov commented on LUCENE-8816: -- I see that in {{BinaryDictionaryWriter}} we

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-01 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853784#comment-16853784 ] Namgyu Kim commented on LUCENE-8816: Thanks! [~tomoko] :D > Decouple Kuromoji's mor

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-01 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853783#comment-16853783 ] Tomoko Uchida commented on LUCENE-8816: --- Hi [~danmuzi], thanks for opening the is

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-01 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853754#comment-16853754 ] Namgyu Kim commented on LUCENE-8816: Thanks for your reply! [~tomoko] I created t

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-01 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853720#comment-16853720 ] Tomoko Uchida commented on LUCENE-8816: --- OK, if you will be able to merge two dict

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-06-01 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853678#comment-16853678 ] Namgyu Kim commented on LUCENE-8816: Oh, you're right. [~tomoko] :D I'll make a new

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-31 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853504#comment-16853504 ] Tomoko Uchida commented on LUCENE-8816: --- {quote}But I think BinaryDirectoryWriter

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-31 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853207#comment-16853207 ] Namgyu Kim commented on LUCENE-8816: {quote}So I thought we can share only Dictionar

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-30 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852706#comment-16852706 ] Tomoko Uchida commented on LUCENE-8816: --- Related to the comment from [~rcmuir], {q

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-30 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852595#comment-16852595 ] Tomoko Uchida commented on LUCENE-8816: --- Thank you guys, for your comments and sug

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852581#comment-16852581 ] Robert Muir commented on LUCENE-8816: - Yeah there is some optimizations specific to

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-30 Thread Christian Moen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852551#comment-16852551 ] Christian Moen commented on LUCENE-8816: Separating out the dictionaries is a gr

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-30 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852084#comment-16852084 ] Namgyu Kim commented on LUCENE-8816: That's a good plan, [~tomoko]! About Tokenizer

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-29 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851574#comment-16851574 ] Jim Ferenczi commented on LUCENE-8816: -- This sounds like a great plan [~tomoko]. De

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-29 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851556#comment-16851556 ] Tomoko Uchida commented on LUCENE-8816: --- I looked over the diffs between current K

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-29 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851477#comment-16851477 ] Tomoko Uchida commented on LUCENE-8816: --- Thaks [~rcmuir], I checked current asser

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-29 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851103#comment-16851103 ] Namgyu Kim commented on LUCENE-8816: Thanks for the answers :D Oh, I think your opi

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850954#comment-16850954 ] Robert Muir commented on LUCENE-8816: - As a suggestion for the first concrete step:

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850233#comment-16850233 ] Tomoko Uchida commented on LUCENE-8816: --- Hi [~danmuzi], thanks for speaking up ab

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849967#comment-16849967 ] Namgyu Kim commented on LUCENE-8816: Hi everybody, Thank you for opening the issue!

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849840#comment-16849840 ] Tomoko Uchida commented on LUCENE-8816: --- Hi [~jim.ferenczi], I just skimmed your

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849778#comment-16849778 ] Jim Ferenczi commented on LUCENE-8816: -- We discussed this when we added the Korean

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849755#comment-16849755 ] Tomoko Uchida commented on LUCENE-8816: --- [~rcmuir] [~sokolov]: Thanks for the comm

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849734#comment-16849734 ] Robert Muir commented on LUCENE-8816: - >From the perspective of this code, the dicti

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849731#comment-16849731 ] Mike Sokolov commented on LUCENE-8816: -- What if we changed the various dictionary c

[jira] [Commented] (LUCENE-8816) Decouple Kuromoji's morphological analyser and its dictionary

2019-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849725#comment-16849725 ] Robert Muir commented on LUCENE-8816: - if the licensing challenge in LUCENE-4056 is