[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875597#comment-16875597 ] ASF subversion and git services commented on LUCENE-8871: - Commit

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874014#comment-16874014 ] Mike Sokolov commented on LUCENE-8871: -- I see, thanks for explaining. I was reading the commit

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874010#comment-16874010 ] Adrien Grand commented on LUCENE-8871: -- The visibility changes are required because our Javadocs

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874009#comment-16874009 ] Mike Sokolov commented on LUCENE-8871: -- I see what you did there [~jpountz]! Thank you for fixing.

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874008#comment-16874008 ] Mike Sokolov commented on LUCENE-8871: -- I see what you did there! Thank you for fixing. I have to

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873980#comment-16873980 ] Adrien Grand commented on LUCENE-8871: -- [~sokolov] I tried to address the precommit failures but

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873979#comment-16873979 ] ASF subversion and git services commented on LUCENE-8871: - Commit

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873947#comment-16873947 ] Mikhail Khludnev commented on LUCENE-8871: -- Pls have a look

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873768#comment-16873768 ] ASF subversion and git services commented on LUCENE-8871: - Commit

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872790#comment-16872790 ] Mike Sokolov commented on LUCENE-8871: -- Thanks for reviewing. FYI I will be delayed a bit in

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872781#comment-16872781 ] Robert Muir commented on LUCENE-8871: - +1 from me. I looked thru the PR, it is just as described.

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871403#comment-16871403 ] Mike Sokolov commented on LUCENE-8871: -- This has been up for a day, and is I think pretty