[jira] [Commented] (LUCENE-8877) TopDocsCollector Should Not Depend on Priority Queue

2019-06-26 Thread Adrien Grand (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873014#comment-16873014
 ] 

Adrien Grand commented on LUCENE-8877:
--

Abstraction increases complexity too, it feels reasonable to me that top-docs 
collectors are backed by a priority queue since this is the go-to data-stucture 
for top-k selection problems? If you need more flexibility, you could directly 
extends Collector as opposed to TopDocsCollector?

> TopDocsCollector Should Not Depend on Priority Queue
> 
>
> Key: LUCENE-8877
> URL: https://issues.apache.org/jira/browse/LUCENE-8877
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Atri Sharma
>Priority: Major
>
> TopDocsCollector is tightly coupled to the notion of priority queue, which is 
> not necessarily a good abstraction to have since the collector really just 
> needs an interface to iterate on and hold docID and score, with possibly 
> shard indexes.
>  
> We should rewrite this to a more simplistic interface with priority queue 
> being the default implementation 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8877) TopDocsCollector Should Not Depend on Priority Queue

2019-06-25 Thread Atri Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872544#comment-16872544
 ] 

Atri Sharma commented on LUCENE-8877:
-

Any thoughts on this? I am envisioning eventually getting to a state where the 
underlying data structure used is opaque to IndexSearcher API. This should 
allow an abstraction with high degree of flexibility 

> TopDocsCollector Should Not Depend on Priority Queue
> 
>
> Key: LUCENE-8877
> URL: https://issues.apache.org/jira/browse/LUCENE-8877
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Atri Sharma
>Priority: Major
>
> TopDocsCollector is tightly coupled to the notion of priority queue, which is 
> not necessarily a good abstraction to have since the collector really just 
> needs an interface to iterate on and hold docID and score, with possibly 
> shard indexes.
>  
> We should rewrite this to a more simplistic interface with priority queue 
> being the default implementation 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org