[jira] [Commented] (LUCENE-8944) "I am authorized to contribute" wording in the Pull Request Template

2019-08-22 Thread Christine Poerschke (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913411#comment-16913411
 ] 

Christine Poerschke commented on LUCENE-8944:
-

Thanks [~janhoy] for your input!

bq. Let’s remove the “I’m authorized” box if it is not needed. ...

+1

bq. ... Better to err on asking legal an extra time if no one have a link to 
such official policy.

LEGAL-475 ticket opened.

> "I am authorized to contribute" wording in the Pull Request Template
> 
>
> Key: LUCENE-8944
> URL: https://issues.apache.org/jira/browse/LUCENE-8944
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Christine Poerschke
>Priority: Minor
>
> This ticket is to consider potential revisions to one of the checklist items 
> in the [pull request 
> template|https://github.com/apache/lucene-solr/blob/master/.github/PULL_REQUEST_TEMPLATE.md]
>  -- its current wording is:
> bq. \[ \] I am authorized to contribute this code to the ASF and have removed 
> any code I do not have a license to distribute.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8944) "I am authorized to contribute" wording in the Pull Request Template

2019-08-06 Thread JIRA


[ 
https://issues.apache.org/jira/browse/LUCENE-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900721#comment-16900721
 ] 

Jan Høydahl commented on LUCENE-8944:
-

+1 to the minor improvements in bullet 1-3

Let’s remove the “I’m authorized” box if it is not needed. I think I have read 
that legally, the very fact that a PR is submitted proves that the submitter 
intends it to be ready for inclusion. Exception is larger pieces of work 
contributed from a company where explicit CLAs may be nd. 

Better to err on asking legal an extra time if no one have a link to such 
official policy.

> "I am authorized to contribute" wording in the Pull Request Template
> 
>
> Key: LUCENE-8944
> URL: https://issues.apache.org/jira/browse/LUCENE-8944
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Christine Poerschke
>Priority: Minor
>
> This ticket is to consider potential revisions to one of the checklist items 
> in the [pull request 
> template|https://github.com/apache/lucene-solr/blob/master/.github/PULL_REQUEST_TEMPLATE.md]
>  -- its current wording is:
> bq. \[ \] I am authorized to contribute this code to the ASF and have removed 
> any code I do not have a license to distribute.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8944) "I am authorized to contribute" wording in the Pull Request Template

2019-08-02 Thread Christine Poerschke (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899040#comment-16899040
 ] 

Christine Poerschke commented on LUCENE-8944:
-

Here's some thoughts that occurred to me this week:
 * "code" could be broadened out to "changes" to include code as well as 
documentation and test contributions.

 * "ASF" could be expanded to "Apache Software Foundation" or "Apache Software 
Foundation (ASF)".

 * Could we sign-post contributors to  with further information that 
may be helpful in a "I don't know if I'm authorized or not." scenario?

 * How to provide helpful feedback for pull requests were the "I am authorized" 
checklist item is unchecked? Is an unchecked checklist item different to a pull 
request that does not have the checklist or the checklist item? If we accept 
pull requests without the checklist item then is it perhaps not strictly 
necessary to have the checklist item?
 ** I've looked around a little in the Apache documentation and at some other 
Apache projects' pull request templates but found no obvious answer to this. 
Perhaps a [Legal Discuss|https://issues.apache.org/jira/projects/LEGAL/issues] 
issue could be opened but first wanted to ask on a project level here.

What do others think?

> "I am authorized to contribute" wording in the Pull Request Template
> 
>
> Key: LUCENE-8944
> URL: https://issues.apache.org/jira/browse/LUCENE-8944
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Christine Poerschke
>Priority: Minor
>
> This ticket is to consider potential revisions to one of the checklist items 
> in the [pull request 
> template|https://github.com/apache/lucene-solr/blob/master/.github/PULL_REQUEST_TEMPLATE.md]
>  -- its current wording is:
> bq. \[ \] I am authorized to contribute this code to the ASF and have removed 
> any code I do not have a license to distribute.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org