[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879706#comment-15879706 ] ASF subversion and git services commented on SOLR-10021: Commit 04bcba77c824125c2ef2feb4c64dfcfc37b48211 in lucene-solr's branch refs/heads/branch_6x from [~erickerickson] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=04bcba7 ] SOLR-10021: Cannot reload a core if it fails initialization. (cherry picked from commit 8367e15) > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > Attachments: SOLR-10021.patch, SOLR-10021.patch > > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879690#comment-15879690 ] ASF subversion and git services commented on SOLR-10021: Commit 8367e159e4a287a34adf6552a5aecfe3b8073d8e in lucene-solr's branch refs/heads/master from [~erickerickson] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8367e15 ] SOLR-10021: Cannot reload a core if it fails initialization. > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > Attachments: SOLR-10021.patch > > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878722#comment-15878722 ] Mike Drob commented on SOLR-10021: -- Needs a CHANGES entry, but otherwise good to commit. > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > Attachments: SOLR-10021.patch > > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878602#comment-15878602 ] Erick Erickson commented on SOLR-10021: --- Just as soon as I get time What do you think the state of the patch is? > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > Attachments: SOLR-10021.patch > > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878527#comment-15878527 ] Mike Drob commented on SOLR-10021: -- [~erickerickson] - thoughts on this one? > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > Attachments: SOLR-10021.patch > > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878526#comment-15878526 ] Mike Drob commented on SOLR-10021: -- [~erickerickson] - thoughts on this one? > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > Attachments: SOLR-10021.patch > > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859147#comment-15859147 ] Mike Drob commented on SOLR-10021: -- I have a rough outline of a patch for this, still needs unit tests though. Will try to upload something by the end of the week. > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10021) Cannot reload a core if it fails initialization.
[ https://issues.apache.org/jira/browse/SOLR-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833296#comment-15833296 ] Erick Erickson commented on SOLR-10021: --- SOLR-10009 should make getting a CoreDescriptor NOT require a SolrCore, which you don't have in this case. > Cannot reload a core if it fails initialization. > > > Key: SOLR-10021 > URL: https://issues.apache.org/jira/browse/SOLR-10021 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson > > Once a core initialization fails, all calls to CoreContainer.getCore() throw > an error forever, including the core admin RELOAD command. > I think that RELOAD (and only RELOAD) should go ahead even after > initialization failure since it is, after all, reloading everything. For any > other core ops since you don't know why the core load failed in the first > place you couldn't rely on the state of the core to try to do anything so > failing is appropriate. > However, the current structure of the code needs a SolrCore to get the > CoreDescriptor which you need to have to, well, reload the core. The work on > SOLR-10007 and associated JIRAs _should_ make it possible to get the > CoreDescriptor without having to have a core already. Once that's possible, > RELOAD will have to distinguish between having a SolrCore already and using > the present reload() method or creating a new core. > We could also consider a new core admin API command. It's always bugged me > that there's an UNLOAD but no LOAD, we've kinda, sorta, maybe been able to > use CREATE. > I think I like making RELOAD smarter though. Consider the scenario where you > make a config change that you mess up. You'd have to change to LOAD when > RELOAD failed. I can be convinced otherwise though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
