[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[ https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464562#comment-16464562 ] Erick Erickson commented on SOLR-10169: --- I'm reluctant to start throwing more stuff at 7.3.1. If this was something that used to work in 7.2 and was broken in 7.3 it would be a different story. But this behavior has been around since forever. So my preference would be to just let it flow into 7.4. I have no objection if someone else wants to backport to 7.3.1, but I don't have the motivation/time, especially as I'll be on vacation soon. > PeerSync will hit an NPE on no response errors when looking for fingerprint. > > > Key: SOLR-10169 > URL: https://issues.apache.org/jira/browse/SOLR-10169 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 6.6, 7.0 >Reporter: Mark Miller >Assignee: Erick Erickson >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-10169.patch, SOLR-10169.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[ https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464246#comment-16464246 ] Varun Thacker commented on SOLR-10169: -- Hi [~erickerickson] should we backport this to Solr 7.3.1 ? > PeerSync will hit an NPE on no response errors when looking for fingerprint. > > > Key: SOLR-10169 > URL: https://issues.apache.org/jira/browse/SOLR-10169 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 6.6, 7.0 >Reporter: Mark Miller >Assignee: Erick Erickson >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-10169.patch, SOLR-10169.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[ https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440447#comment-16440447 ] ASF subversion and git services commented on SOLR-10169: Commit e97044338e04b03184316bb0f537d7a80305be80 in lucene-solr's branch refs/heads/branch_7x from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e970443 ] SOLR-10169: PeerSync will hit an NPE on no response errors when looking for fingerprint. (cherry picked from commit a417a2c) > PeerSync will hit an NPE on no response errors when looking for fingerprint. > > > Key: SOLR-10169 > URL: https://issues.apache.org/jira/browse/SOLR-10169 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 6.6, 7.0 >Reporter: Mark Miller >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-10169.patch, SOLR-10169.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[ https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440379#comment-16440379 ] ASF subversion and git services commented on SOLR-10169: Commit a417a2cd6a612e7ed1a99b14230c3f08e455f9c1 in lucene-solr's branch refs/heads/master from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a417a2c ] SOLR-10169: PeerSync will hit an NPE on no response errors when looking for fingerprint. > PeerSync will hit an NPE on no response errors when looking for fingerprint. > > > Key: SOLR-10169 > URL: https://issues.apache.org/jira/browse/SOLR-10169 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 6.6, 7.0 >Reporter: Mark Miller >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-10169.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[
https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438380#comment-16438380
]
Lucene/Solr QA commented on SOLR-10169:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 33s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 96m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.ZkControllerTest |
| | solr.search.TestSolr4Spatial2 |
| | solr.cloud.autoscaling.sim.TestTriggerIntegration |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-10169 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918807/SOLR-10169.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 93f9a65 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015 |
| Default Java | 1.8.0_152 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/53/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/53/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/53/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> PeerSync will hit an NPE on no response errors when looking for fingerprint.
>
>
> Key: SOLR-10169
> URL: https://issues.apache.org/jira/browse/SOLR-10169
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.6, 7.0
>Reporter: Mark Miller
>Assignee: Erick Erickson
>Priority: Major
> Attachments: SOLR-10169.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[
https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436255#comment-16436255
]
Erick Erickson commented on SOLR-10169:
---
PeerSync.alreadyInSync() eventually calls HttpShardHandler.take(), which has
this line:
if (bailOnError && rsp.getException() != null) return rsp;
Then takes the response and throws an NPE on line 391:
Object replicaFingerprint =
srsp.getSolrResponse().getResponse().get("fingerprint");
It's not clear to me whether it's the getSolrResponse() or
getSolrResponse().getResponse() that throws the error.
The problem here is that the exception bypasses the rest of the peer sync
logic and goes into full sync.
I'll attach a patch shortly that tests both for null. I Haven't done anything
except compile it yet. It may still go into full sync, but at least there'll be
a chance to recover.
I'll commit this over the weekend unless there are objections.
The line numbers match up reasonably between the various versions of that file
for the dates of the JIRAs.
> PeerSync will hit an NPE on no response errors when looking for fingerprint.
>
>
> Key: SOLR-10169
> URL: https://issues.apache.org/jira/browse/SOLR-10169
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.6, 7.0
>Reporter: Mark Miller
>Assignee: Erick Erickson
>Priority: Major
> Attachments: SOLR-10169.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[ https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436248#comment-16436248 ] Erick Erickson commented on SOLR-10169: --- Pretty certain these are the same thing. Fix coming > PeerSync will hit an NPE on no response errors when looking for fingerprint. > > > Key: SOLR-10169 > URL: https://issues.apache.org/jira/browse/SOLR-10169 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[ https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056738#comment-16056738 ] Pushkar Raste commented on SOLR-10169: -- Is this duplicate of SOLR-9915 > PeerSync will hit an NPE on no response errors when looking for fingerprint. > > > Key: SOLR-10169 > URL: https://issues.apache.org/jira/browse/SOLR-10169 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10169) PeerSync will hit an NPE on no response errors when looking for fingerprint.
[
https://issues.apache.org/jira/browse/SOLR-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873929#comment-15873929
]
Mark Miller commented on SOLR-10169:
You see a ton of this NPE in the chaosmonkeysafeleader tests:
{noformat}
[junit4] 2> 232568 WARN (qtp1715259784-426) [n:127.0.0.1:41587_
c:testcollection s:shard1 x:testcollection_shard1_replica1]
o.e.j.s.ServletHandler /collection1/get
[junit4] 2> org.apache.solr.common.SolrException: Error processing the
request. CoreContainer is either not initialized or shutting down.
[junit4] 2>at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:307)
[junit4] 2>at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:298)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699)
[junit4] 2>at
org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
[junit4] 2>at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
[junit4] 2>at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
[junit4] 2>at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
[junit4] 2>at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
[junit4] 2>at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
[junit4] 2>at
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:395)
[junit4] 2>at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
[junit4] 2>at
org.eclipse.jetty.server.Server.handle(Server.java:534)
[junit4] 2>at
org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
[junit4] 2>at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
[junit4] 2>at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273)
[junit4] 2>at
org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95)
[junit4] 2>at
org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
[junit4] 2>at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
[junit4] 2>at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
[junit4] 2>at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
[junit4] 2>at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
[junit4] 2>at
org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
[junit4] 2>at java.lang.Thread.run(Thread.java:745)
[junit4] 2> 232578 ERROR (qtp2032257318-515) [n:127.0.0.1:35761_
c:collection1 s:shard2 r:core_node7 x:collection1] o.a.s.h.RequestHandlerBase
java.lang.NullPointerException
[junit4] 2>at
org.apache.solr.update.PeerSync.alreadyInSync(PeerSync.java:373)
[junit4] 2>at
org.apache.solr.update.PeerSync.sync(PeerSync.java:243)
[junit4] 2>at
org.apache.solr.handler.component.RealTimeGetComponent.processSync(RealTimeGetComponent.java:985)
[junit4] 2>at
org.apache.solr.handler.component.RealTimeGetComponent.processGetVersions(RealTimeGetComponent.java:947)
[junit4] 2>at
org.apache.solr.handler.component.RealTimeGetComponent.process(RealTimeGetComponent.java:126)
[junit4] 2>at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:294)
[junit4] 2>at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:171)
[junit4] 2>at
org.apache.solr.core.SolrCore.execute(SolrCore.java:2413)
[junit4] 2>at
org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:722)
[junit4] 2>at
org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:528)
[junit4] 2>at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:347)
[junit4] 2>at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:298)
[junit4] 2>at
