[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-19 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516747#comment-16516747 ] Cao Manh Dat commented on SOLR-11216: - Attached a patch including the optimization metionted above,

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-17 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515335#comment-16515335 ] Cao Manh Dat commented on SOLR-11216: - Attached a patch with refactoring. The code seems much cleaner

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-15 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514525#comment-16514525 ] Cao Manh Dat commented on SOLR-11216: - Thank guys for your reviews. This is a rough patch which needs

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-15 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514102#comment-16514102 ] hamada commented on SOLR-11216: --- General review comments, some not related to the patch but relevant In

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-15 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513887#comment-16513887 ] Cao Manh Dat commented on SOLR-11216: - Attached patch for Solution 2. Created a new class

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-13 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511005#comment-16511005 ] Cao Manh Dat commented on SOLR-11216: - Attached patch for anyone wants to reproduce problems of

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-13 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511004#comment-16511004 ] Cao Manh Dat commented on SOLR-11216: - After spent a day adding more test and debugging problem. I

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-12 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509971#comment-16509971 ] hamada commented on SOLR-11216: --- from 20,000 foot level. Any time based solution is just brittle, solution

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-12 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509691#comment-16509691 ] Cao Manh Dat commented on SOLR-11216: - Attached a patch for this ticket, based on Solution 3. It

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-10 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507649#comment-16507649 ] Cao Manh Dat commented on SOLR-11216: - The problem here relates to "on-wire" updates which get

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2017-11-20 Thread Pushkar Raste (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260117#comment-16260117 ] Pushkar Raste commented on SOLR-11216: -- [~caomanhdat] Can this fail if the leader processes updates