[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660984#comment-16660984 ] David Smiley commented on SOLR-11770: - Looking at this code now in BaseEditorialTransformer. Shouldn't the String case be similar to IndexableField in using {{ft.readableToIndexed}}? The field type dictates the transformation. > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > Fix For: 7.5, master (8.0) > > Attachments: SOLR-11770.patch, SOLR-11770.patch > > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571083#comment-16571083 ] ASF subversion and git services commented on SOLR-11770: Commit 21e8a84296cf3ba15879beee1f77809a2ce9544b in lucene-solr's branch refs/heads/branch_7x from [~cp.erick...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21e8a84 ] SOLR-11770: NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors (cherry picked from commit 96e8392921792b9ec281c28f28f49b50f998ceed) > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-11770.patch, SOLR-11770.patch > > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571084#comment-16571084 ] ASF subversion and git services commented on SOLR-11770: Commit 5a7cb7ed3dba0c31afa58365c115530625b91ad7 in lucene-solr's branch refs/heads/branch_7x from [~cp.erick...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5a7cb7e ] SOLR-11770: NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors, forgot to add CHANGES.txt (cherry picked from commit 08ca54f1f89eb98f6a3238f0f91c1f8383c12119) > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-11770.patch, SOLR-11770.patch > > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571069#comment-16571069 ] ASF subversion and git services commented on SOLR-11770: Commit 08ca54f1f89eb98f6a3238f0f91c1f8383c12119 in lucene-solr's branch refs/heads/master from [~cp.erick...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=08ca54f ] SOLR-11770: NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors, forgot to add CHANGES.txt > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-11770.patch > > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571068#comment-16571068 ] ASF subversion and git services commented on SOLR-11770: Commit 96e8392921792b9ec281c28f28f49b50f998ceed in lucene-solr's branch refs/heads/master from [~cp.erick...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=96e8392 ] SOLR-11770: NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-11770.patch > > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568939#comment-16568939 ] Erick Erickson commented on SOLR-11770: --- Here's a patch. The fix for TVRH isn't very interesting, but there are a couple of things I'd like to draw your attention to [~dsmiley] and [~caomanhdat2] in particular. 1> I had to make several methods in RetrieveFieldOptimizer public to use them outside the package RFO is defined in. I consider this a stopgap until we tackle SOLR-12625. 2> Along the way I randomized the stored/docValues fields for "schema.xml" for my TVRH test. The defaults are as they are now so it "shouldn't change anything". HOWEVER: 2a> I screwed it up on the first attempt and set both to "true" by default the first time, and then QueryElevationComponentTest started failing. The fix (which seems safe, but isn't really complete) is in BaseEditorialTransformer. Anyone interested please take a look. All tests pass. 2b> It's scary that turning on docValues=true stored=true causes this kind of unintended consequence, how many others are lurking around? I propose we randomize the two environment variables you'll see in schema.xml in this patch in the framework and flush out any more. This presupposes that the three valid combinations should all be supported (stored=false,docValues=false doesn't make sense). I'll commit this in over the weekend probably, the interesting work will be in SOLR-12625 > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-11770.patch > > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548071#comment-16548071 ] David Smiley commented on SOLR-11770: - Just curious, what do people actually use TVRH for? Purely diagnostics or some greater production purpose? > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson >Priority: Major > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136) >at > org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671) >at >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322508#comment-16322508 ] Nikolay Martynov commented on SOLR-11770: - There is a related story for 'tvrh needs stored unique key': https://issues.apache.org/jira/browse/SOLR-11792 > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273) >at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95) >at > org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148) >at > org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136) >at > org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671) >at > org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589) >
[jira] [Commented] (SOLR-11770) NPE in tvrh if no field is specified and document doesn't contain any fields with term vectors
[ https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321719#comment-16321719 ] Erick Erickson commented on SOLR-11770: --- On another note: If I switch my field from stored="true", docValues="false" to stored="false", docValues="true" the output changes. It seems like having the ID field present in docValues should allow it to be returned. With stored=false, docValues=true: "termVectors":[]} With stored=true, docValues=false: "termVectors":[ "GB18030TEST",[ "uniqueKey","GB18030TEST"], "SP2514N",[ "uniqueKey","SP2514N"], "6H500F0",[ "uniqueKey","6H500F0"], "F8V7067-APL-KIT",[ "uniqueKey","F8V7067-APL-KIT"], "IW-02",[ "uniqueKey","IW-02"], "MA147LL/A",[ "uniqueKey","MA147LL/A", "includes",[ "cable",[], "earbud",[], "headphones",[], "usb",[]]], "adata",[ "uniqueKey","adata"], "apple",[ "uniqueKey","apple"], "asus",[ "uniqueKey","asus"], "ati",[ "uniqueKey","ati"]]} > NPE in tvrh if no field is specified and document doesn't contain any fields > with term vectors > -- > > Key: SOLR-11770 > URL: https://issues.apache.org/jira/browse/SOLR-11770 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 6.6.2 >Reporter: Nikolay Martynov >Assignee: Erick Erickson > > It looks like if {{tvrh}} request doesn't contain {{fl}} parameter and > document doesn't have any fields with term vectors then Solr returns NPE. > Request: > {{tvrh?shards.qt=/tvrh=field%3Avalue=json=id%3A123=true}}. > On our 'old' schema we had some fields with {{termVectors}} and even more > fields with position data. In our new schema we tried to remove unused data > so we dropped a lot of position data and some term vectors. > Our documents are 'sparsely' populated - not all documents contain all fields. > Above request was returning fine for our 'old' schema and returns 500 for our > 'new' schema - on exactly same Solr (6.6.2). > Stack trace: > {code} > 2017-12-18 01:15:00.958 ERROR (qtp255041198-46697) [c:test s:shard3 > r:core_node11 x:test_shard3_replica1] o.a.s.h.RequestHandlerBase > java.lang.NullPointerException >at > org.apache.solr.handler.component.TermVectorComponent.process(TermVectorComponent.java:324) >at > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:296) >at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173) >at org.apache.solr.core.SolrCore.execute(SolrCore.java:2482) >at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723) >at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361) >at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305) >at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1691) >at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) >at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) >at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) >at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512) >at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) >at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) >at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) >at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213) >at > org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at > org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:335) >at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) >at org.eclipse.jetty.server.Server.handle(Server.java:534) >at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) >at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) >at >