[jira] [Commented] (SOLR-12076) Remove more usages of printLayout in CDCR tests
[ https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395644#comment-16395644 ] Varun Thacker commented on SOLR-12076: -- Until INFRA-15850 is resolved the user tagged with the commit will not be me > Remove more usages of printLayout in CDCR tests > --- > > Key: SOLR-12076 > URL: https://issues.apache.org/jira/browse/SOLR-12076 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Varun Thacker >Assignee: Varun Thacker >Priority: Minor > Attachments: SOLR-12076.patch > > > All the CDCR tests simply print everything stored in ZooKeeper when we start > the servers. > It adds no value in my option and simply generates noise. > In general we should remove printLayoutToStdOut which prints everything and > pass a parameter to print only a particular set of znodes which they care > about. For example if the leader election tests fail print everything related > to that collection and not print everything including the configs. > It's also a public API so I don't want to tackle this in the interest of > time. I plan on specifically tackling the usage in CDCR tests and removing > them. SOLR-6090 is also related for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12076) Remove more usages of printLayout in CDCR tests
[ https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395628#comment-16395628 ] ASF subversion and git services commented on SOLR-12076: Commit 6b8a20264b83f997bb6e936bce20c8a20c38c004 in lucene-solr's branch refs/heads/branch_7x from [~varun_saxena] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6b8a202 ] SOLR-12076: Remove unnecessary printLayout usage in CDCR tests (cherry picked from commit 2a0b776) > Remove more usages of printLayout in CDCR tests > --- > > Key: SOLR-12076 > URL: https://issues.apache.org/jira/browse/SOLR-12076 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Varun Thacker >Assignee: Varun Thacker >Priority: Minor > Attachments: SOLR-12076.patch > > > All the CDCR tests simply print everything stored in ZooKeeper when we start > the servers. > It adds no value in my option and simply generates noise. > In general we should remove printLayoutToStdOut which prints everything and > pass a parameter to print only a particular set of znodes which they care > about. For example if the leader election tests fail print everything related > to that collection and not print everything including the configs. > It's also a public API so I don't want to tackle this in the interest of > time. I plan on specifically tackling the usage in CDCR tests and removing > them. SOLR-6090 is also related for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12076) Remove more usages of printLayout in CDCR tests
[ https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395617#comment-16395617 ] ASF subversion and git services commented on SOLR-12076: Commit 2a0b7767abcfc1e6a78abb784120d913489da7b8 in lucene-solr's branch refs/heads/master from [~varun_saxena] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2a0b776 ] SOLR-12076: Remove unnecessary printLayout usage in CDCR tests > Remove more usages of printLayout in CDCR tests > --- > > Key: SOLR-12076 > URL: https://issues.apache.org/jira/browse/SOLR-12076 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Varun Thacker >Assignee: Varun Thacker >Priority: Minor > Attachments: SOLR-12076.patch > > > All the CDCR tests simply print everything stored in ZooKeeper when we start > the servers. > It adds no value in my option and simply generates noise. > In general we should remove printLayoutToStdOut which prints everything and > pass a parameter to print only a particular set of znodes which they care > about. For example if the leader election tests fail print everything related > to that collection and not print everything including the configs. > It's also a public API so I don't want to tackle this in the interest of > time. I plan on specifically tackling the usage in CDCR tests and removing > them. SOLR-6090 is also related for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12076) Remove more usages of printLayout in CDCR tests
[ https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393708#comment-16393708 ] Varun Thacker commented on SOLR-12076: -- Simple patch. I'll run tests and preccommit and then commit this shortly. > Remove more usages of printLayout in CDCR tests > --- > > Key: SOLR-12076 > URL: https://issues.apache.org/jira/browse/SOLR-12076 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Varun Thacker >Priority: Minor > Attachments: SOLR-12076.patch > > > All the CDCR tests simply print everything stored in ZooKeeper when we start > the servers. > It adds no value in my option and simply generates noise. > In general we should remove printLayoutToStdOut which prints everything and > pass a parameter to print only a particular set of znodes which they care > about. For example if the leader election tests fail print everything related > to that collection and not print everything including the configs. > It's also a public API so I don't want to tackle this in the interest of > time. I plan on specifically tackling the usage in CDCR tests and removing > them. SOLR-6090 is also related for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
