[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2019-06-13 Thread Colvin Cowie (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862823#comment-16862823 ] Colvin Cowie commented on SOLR-12142: - [~noble.paul] I raised SOLR-13545 thanks > EmbeddedSolrServer

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2019-06-12 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862728#comment-16862728 ] Noble Paul commented on SOLR-12142: --- [~cjcowie] Yes, it is not closed . Please open a new ticket >

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2019-06-12 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862511#comment-16862511 ] Mikhail Khludnev commented on SOLR-12142: - I agree with [~cjcowie]. WDYT, [~noble.paul],

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2019-06-12 Thread Colvin Cowie (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861912#comment-16861912 ] Colvin Cowie commented on SOLR-12142: - Hi [~noble.paul] I suspect that the changes in this issue

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505611#comment-16505611 ] ASF subversion and git services commented on SOLR-12142: Commit

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505293#comment-16505293 ] David Smiley commented on SOLR-12142: - needs to go to the branch_7_4 too. > EmbeddedSolrServer

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504912#comment-16504912 ] ASF subversion and git services commented on SOLR-12142: Commit

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504894#comment-16504894 ] ASF subversion and git services commented on SOLR-12142: Commit

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504645#comment-16504645 ] David Smiley commented on SOLR-12142: - Looks like we've got some real test failures here in

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504629#comment-16504629 ] Noble Paul commented on SOLR-12142: --- bq. I assume the change to SolrQueryRequestBase was

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-07 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504379#comment-16504379 ] Lucene/Solr QA commented on SOLR-12142: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-06 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503603#comment-16503603 ] David Smiley commented on SOLR-12142: - Thanks for the quick turnaround! * I assume the change to

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-06 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503036#comment-16503036 ] Noble Paul commented on SOLR-12142: --- [~dsmiley] pls review the patch > EmbeddedSolrServer should use

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-06-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502777#comment-16502777 ] David Smiley commented on SOLR-12142: - Now that the SolrTextTagger is in Solr, it's test

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-04-20 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445866#comment-16445866 ] David Smiley commented on SOLR-12142: - So this method, EmbeddedSolrServer.request(...) confusingly

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-04-18 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443555#comment-16443555 ] Noble Paul commented on SOLR-12142: --- I'll reopen the ticket. You can post a patch with a testcase and I

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-04-18 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443543#comment-16443543 ] David Smiley commented on SOLR-12142: - I wasn't expecting this is in committable shape yet... I'll

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-04-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443538#comment-16443538 ] ASF subversion and git services commented on SOLR-12142: Commit

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-04-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443535#comment-16443535 ] ASF subversion and git services commented on SOLR-12142: Commit

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-03-31 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421198#comment-16421198 ] Noble Paul commented on SOLR-12142: --- bq.– assuming BinaryRequestWriter().write is used? Then I guess

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-03-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421175#comment-16421175 ] David Smiley commented on SOLR-12142: - bq. We cannot ... -- assuming BinaryRequestWriter().write is

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-03-30 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421115#comment-16421115 ] Noble Paul commented on SOLR-12142: --- We cannot have any other content type handled other than

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-03-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420592#comment-16420592 ] David Smiley commented on SOLR-12142: - Oh clever; I didn't know {{new

[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter

2018-03-29 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418508#comment-16418508 ] Mikhail Khludnev commented on SOLR-12142: - This patch uses java.io.BAOS with expensive resizing.