[jira] [Commented] (SOLR-12344) SolrSlf4jReporter doesn't set MDC context
[
https://issues.apache.org/jira/browse/SOLR-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566748#comment-16566748
]
ASF subversion and git services commented on SOLR-12344:
Commit 32e417959a8098505812b87a275844f2cc98b1d1 in lucene-solr's branch
refs/heads/branch_7x from Andrzej Bialecki
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=32e4179 ]
SOLR-12344: SolrSlf4jReporter doesn't set MDC context.
> SolrSlf4jReporter doesn't set MDC context
> -
>
> Key: SOLR-12344
> URL: https://issues.apache.org/jira/browse/SOLR-12344
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Varun Thacker
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.5
>
> Attachments: SOLR-12344.patch
>
>
> I setup a slf4j reporter like this on master
> solr.xml
> {code:java}
>
>class="org.apache.solr.metrics.reporters.SolrSlf4jReporter">
> 1
> UPDATE./update.requestTimes
> update_logger
>
> {code}
> log4j2.xml
> {code:java}
>
>
>
>
>
>
>
> %-4r [%t] %-5p %c %x [%X{collection} %X{shard} %X{replica}
> %X{core}] %c; %m%n
>
>
>
> name="RollingFile"
> fileName="${sys:solr.log.dir}/solr.log"
> filePattern="${sys:solr.log.dir}/solr.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
> name="RollingMetricFile"
> fileName="${sys:solr.log.dir}/solr_metric.log"
> filePattern="${sys:solr.log.dir}/solr_metric.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> The output I get from the solr_metric.log file is like this
> {code:java}
> INFO - 2018-05-11 15:31:16.009; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds
> INFO - 2018-05-11 15:31:17.010; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds
> INFO - 2018-05-11 15:31:18.010; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds{code}
> On a JVM which has multiple cores, this will become impossible to tell where
> it's coming from if MDC context is not set
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12344) SolrSlf4jReporter doesn't set MDC context
[
https://issues.apache.org/jira/browse/SOLR-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566707#comment-16566707
]
ASF subversion and git services commented on SOLR-12344:
Commit 5de10c79668bf786d9699db992bf85e2f4beb8b4 in lucene-solr's branch
refs/heads/master from Andrzej Bialecki
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5de10c7 ]
SOLR-12344: SolrSlf4jReporter doesn't set MDC context.
> SolrSlf4jReporter doesn't set MDC context
> -
>
> Key: SOLR-12344
> URL: https://issues.apache.org/jira/browse/SOLR-12344
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Varun Thacker
>Assignee: Andrzej Bialecki
>Priority: Major
> Attachments: SOLR-12344.patch
>
>
> I setup a slf4j reporter like this on master
> solr.xml
> {code:java}
>
>class="org.apache.solr.metrics.reporters.SolrSlf4jReporter">
> 1
> UPDATE./update.requestTimes
> update_logger
>
> {code}
> log4j2.xml
> {code:java}
>
>
>
>
>
>
>
> %-4r [%t] %-5p %c %x [%X{collection} %X{shard} %X{replica}
> %X{core}] %c; %m%n
>
>
>
> name="RollingFile"
> fileName="${sys:solr.log.dir}/solr.log"
> filePattern="${sys:solr.log.dir}/solr.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
> name="RollingMetricFile"
> fileName="${sys:solr.log.dir}/solr_metric.log"
> filePattern="${sys:solr.log.dir}/solr_metric.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> The output I get from the solr_metric.log file is like this
> {code:java}
> INFO - 2018-05-11 15:31:16.009; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds
> INFO - 2018-05-11 15:31:17.010; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds
> INFO - 2018-05-11 15:31:18.010; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds{code}
> On a JVM which has multiple cores, this will become impossible to tell where
> it's coming from if MDC context is not set
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12344) SolrSlf4jReporter doesn't set MDC context
[
https://issues.apache.org/jira/browse/SOLR-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566195#comment-16566195
]
Lucene/Solr QA commented on SOLR-12344:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 42m 44s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.cdcr.CdcrBidirectionalTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12344 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12933963/SOLR-12344.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu
Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 64573c1 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/156/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/156/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/156/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> SolrSlf4jReporter doesn't set MDC context
> -
>
> Key: SOLR-12344
> URL: https://issues.apache.org/jira/browse/SOLR-12344
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Varun Thacker
>Assignee: Andrzej Bialecki
>Priority: Major
> Attachments: SOLR-12344.patch
>
>
> I setup a slf4j reporter like this on master
> solr.xml
> {code:java}
>
>class="org.apache.solr.metrics.reporters.SolrSlf4jReporter">
> 1
> UPDATE./update.requestTimes
> update_logger
>
> {code}
> log4j2.xml
> {code:java}
>
>
>
>
>
>
>
> %-4r [%t] %-5p %c %x [%X{collection} %X{shard} %X{replica}
> %X{core}] %c; %m%n
>
>
>
> name="RollingFile"
> fileName="${sys:solr.log.dir}/solr.log"
> filePattern="${sys:solr.log.dir}/solr.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
> name="RollingMetricFile"
> fileName="${sys:solr.log.dir}/solr_metric.log"
> filePattern="${sys:solr.log.dir}/solr_metric.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> The output I get from the solr_metric.log file is like this
> {code:java}
> INFO - 2018-05-11 15:31:16.009; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0,
[jira] [Commented] (SOLR-12344) SolrSlf4jReporter doesn't set MDC context
[
https://issues.apache.org/jira/browse/SOLR-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565877#comment-16565877
]
Andrzej Bialecki commented on SOLR-12344:
--
This patch adds support for MDC logging to all reporters that need it -
subclasses of {{SolrMetricReporter}} can obtain the current values of MDC
context (including properties such as core, node, shard, replica, etc) in their
{{init()}} method.
> SolrSlf4jReporter doesn't set MDC context
> -
>
> Key: SOLR-12344
> URL: https://issues.apache.org/jira/browse/SOLR-12344
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Varun Thacker
>Assignee: Andrzej Bialecki
>Priority: Major
> Attachments: SOLR-12344.patch
>
>
> I setup a slf4j reporter like this on master
> solr.xml
> {code:java}
>
>class="org.apache.solr.metrics.reporters.SolrSlf4jReporter">
> 1
> UPDATE./update.requestTimes
> update_logger
>
> {code}
> log4j2.xml
> {code:java}
>
>
>
>
>
>
>
> %-4r [%t] %-5p %c %x [%X{collection} %X{shard} %X{replica}
> %X{core}] %c; %m%n
>
>
>
> name="RollingFile"
> fileName="${sys:solr.log.dir}/solr.log"
> filePattern="${sys:solr.log.dir}/solr.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
> name="RollingMetricFile"
> fileName="${sys:solr.log.dir}/solr_metric.log"
> filePattern="${sys:solr.log.dir}/solr_metric.log.%i" >
>
>
> %-5p - %d{-MM-dd HH:mm:ss.SSS}; [%X{collection} %X{shard}
> %X{replica} %X{core}] %c; %m%n
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> The output I get from the solr_metric.log file is like this
> {code:java}
> INFO - 2018-05-11 15:31:16.009; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds
> INFO - 2018-05-11 15:31:17.010; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds
> INFO - 2018-05-11 15:31:18.010; [ ] update_logger; type=TIMER,
> name=UPDATE./update.requestTimes, count=0, min=0.0, max=0.0, mean=0.0,
> stddev=0.0, median=0.0, p75=0.0, p95=0.0, p98=0.0, p99=0.0, p999=0.0,
> mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second,
> duration_unit=milliseconds{code}
> On a JVM which has multiple cores, this will become impossible to tell where
> it's coming from if MDC context is not set
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
